Quickfix for Undefined Offset notice#81
Open
rococodogs wants to merge 1 commit into
Open
Conversation
Uses `<` instead of `<=` in the `for` loop within `Entry::applyAttributes` to prevent an Undefined Offset notice from being thrown.
|
👍 |
|
Just a heads up, this is already fixed in the main source where this master was pulled from (https://github.com/Adldap2/Adldap2). |
|
So what is the difference between adldap2 vs adldap packages? Why is it named like that? why not just create a separate branch? |
|
Because the original author wasn't available to maintain or accept pull requests (as you can see by the massive amount of forks). I've been given push rights to this repository, but I won't maintain this without administrator rights. I can't create branches with push rights either. |
|
Ok thanks:) |
|
My bad, it just wasn't in the wiki :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
<instead of<=in theforloop withinEntry::applyAttributesto prevent an Undefined Offset notice from being thrown.