Skip to content

Commit 61bbcc2

Browse files
author
Nicolas AMBROISE
committed
Improve accessibility of carousel indicators
1 parent bd4983a commit 61bbcc2

File tree

1 file changed

+5
-4
lines changed
  • content/src/content/jcr_root/apps/core/wcm/components/carousel/v1/carousel

1 file changed

+5
-4
lines changed

content/src/content/jcr_root/apps/core/wcm/components/carousel/v1/carousel/carousel.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,21 @@
2929
data-cmp-data-layer="${carousel.data.json}"
3030
data-placeholder-text="${wcmmode.edit && 'Please add Carousel components here' @ i18n}">
3131
<sly data-sly-call="${controlsTemplate.controls @ carousel=carousel}" data-sly-test="${carousel.controlsPrepended}"></sly>
32-
<ol class="cmp-carousel__indicators"
32+
<div class="cmp-carousel__indicators"
3333
role="tablist"
3434
aria-label="${carousel.accessibilityTablist || 'Choose a slide to display' @ i18n}"
3535
data-cmp-hook-carousel="indicators">
36-
<li data-sly-repeat.item="${items}"
36+
<button data-sly-repeat.item="${items}"
3737
id="${item.id}-tab"
3838
class="cmp-carousel__indicator${item.name == carousel.activeItem ? ' cmp-carousel__indicator--active' : ''}"
3939
role="tab"
40+
type="button"
4041
aria-controls="${item.id}-tabpanel"
4142
title="${'Slide {0}' @ format=[itemList.count], i18n}"
4243
data-cmp-hook-carousel="indicator"
4344
aria-selected="${item.name == carousel.activeItem ? true : false}"
44-
tabindex="${item.name == carousel.activeItem ? '0' : '-1'}">${'Slide {0}' @ format=[itemList.count], i18n}</li>
45-
</ol>
45+
tabindex="${item.name == carousel.activeItem ? '0' : '-1'}">${'Slide {0}' @ format=[itemList.count], i18n}</button>
46+
</div>
4647
<div data-sly-set.items="${carousel.children || carousel.items}"
4748
data-sly-test="${items && items.size > 0}"
4849
class="cmp-carousel__content"

0 commit comments

Comments
 (0)