Skip to content

Commit e519171

Browse files
committed
feat(picker-markup): add shirt size within template
1 parent 74d5b2a commit e519171

File tree

4 files changed

+19
-30
lines changed

4 files changed

+19
-30
lines changed

components/dropzone/index.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868

6969
&.is-dragged {
7070
--mod-drop-zone-border-style: var(--mod-drop-zone-border-style-dragged, solid);
71-
--mod-drop-zone-background-color: rgba(var(--spectrum-drop-zone-background-color), var(--mod-drop-zone-background-color-opacity, var(--spectrum-drop-zone-dragged-background-color)));
71+
--mod-drop-zone-background-color: rgb(var(--spectrum-drop-zone-background-color), var(--mod-drop-zone-background-color-opacity, var(--spectrum-drop-zone-dragged-background-color)));
7272
--spectrum-drop-zone-border-color: var(--highcontrast-drop-zone-border-color-hover, var(--mod-drop-zone-border-color-hover, var(--spectrum-drop-zone-border-color-hover)));
7373

7474
/* Updated values for a nested illustrated message when state changes */
@@ -83,7 +83,7 @@
8383

8484
&.is-filled {
8585
/* note: the below applies to .is-filled.is-dragged but works here b/c dragged is the only state applying background color */
86-
--mod-drop-zone-background-color: rgba(var(--spectrum-drop-zone-background-color), var(--mod-drop-zone-background-color-opacity-filled, var(--spectrum-drop-zone-background-color-opacity-filled)));
86+
--mod-drop-zone-background-color: rgb(var(--spectrum-drop-zone-background-color), var(--mod-drop-zone-background-color-opacity-filled, var(--spectrum-drop-zone-background-color-opacity-filled)));
8787

8888
/* Updated values for a nested illustrated message when state changes */
8989
--mod-illustrated-message-display: none;

components/picker/dist/metadata.json

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"sourceFile": "index.css",
33
"selectors": [
44
".spectrum-Picker",
5-
".spectrum-Picker + .spectrum-Popover--bottom-start.is-open",
65
".spectrum-Picker .spectrum-Picker-icon",
76
".spectrum-Picker .spectrum-Picker-label",
87
".spectrum-Picker .spectrum-ProgressCircle",
@@ -13,17 +12,15 @@
1312
".spectrum-Picker--quiet:focus-visible:after",
1413
".spectrum-Picker--sideLabel",
1514
".spectrum-Picker--sizeL",
16-
".spectrum-Picker--sizeL + .spectrum-Popover--bottom-start.is-open",
1715
".spectrum-Picker--sizeS",
18-
".spectrum-Picker--sizeS + .spectrum-Popover--bottom-start.is-open",
1916
".spectrum-Picker--sizeXL",
20-
".spectrum-Picker--sizeXL + .spectrum-Popover--bottom-start.is-open",
2117
".spectrum-Picker-label",
2218
".spectrum-Picker-label.is-placeholder",
2319
".spectrum-Picker-label.is-placeholder:active",
2420
".spectrum-Picker-label.is-placeholder:hover",
2521
".spectrum-Picker-menuIcon",
2622
".spectrum-Picker-menuIcon:active",
23+
".spectrum-Picker-popover",
2724
".spectrum-Picker-validationIcon",
2825
".spectrum-Picker.is-disabled",
2926
".spectrum-Picker.is-disabled .spectrum-Picker-icon",
@@ -123,6 +120,7 @@
123120
"--mod-picker-min-inline-size-quiet",
124121
"--mod-picker-placeholder-font-style",
125122
"--mod-picker-placeholder-font-weight",
123+
"--mod-picker-popover-animation-distance",
126124
"--mod-picker-spacing-bottom-to-text",
127125
"--mod-picker-spacing-edge-to-disclosure-icon",
128126
"--mod-picker-spacing-edge-to-disclosure-icon-quiet",
@@ -131,7 +129,6 @@
131129
"--mod-picker-spacing-icon-to-disclosure-icon",
132130
"--mod-picker-spacing-label-to-picker",
133131
"--mod-picker-spacing-label-to-picker-quiet",
134-
"--mod-picker-spacing-picker-to-popover",
135132
"--mod-picker-spacing-starting-icon-to-text",
136133
"--mod-picker-spacing-text-to-icon-inline-end",
137134
"--mod-picker-spacing-top-to-alert-icon",
@@ -196,7 +193,6 @@
196193
"--spectrum-picker-spacing-icon-to-disclosure-icon",
197194
"--spectrum-picker-spacing-label-to-picker",
198195
"--spectrum-picker-spacing-label-to-picker-quiet",
199-
"--spectrum-picker-spacing-picker-to-popover",
200196
"--spectrum-picker-spacing-starting-icon-to-text",
201197
"--spectrum-picker-spacing-text-to-icon-inline-end",
202198
"--spectrum-picker-spacing-top-to-alert-icon",
@@ -227,9 +223,7 @@
227223
"--spectrum-component-size-difference-down",
228224
"--spectrum-component-size-width-ratio-down",
229225
"--spectrum-component-to-menu-extra-large",
230-
"--spectrum-component-to-menu-large",
231226
"--spectrum-component-to-menu-medium",
232-
"--spectrum-component-to-menu-small",
233227
"--spectrum-component-top-to-text-100",
234228
"--spectrum-component-top-to-text-200",
235229
"--spectrum-component-top-to-text-300",
@@ -302,7 +296,8 @@
302296
"passthroughs": [
303297
"--mod-button-animation-duration",
304298
"--mod-button-font-family",
305-
"--mod-button-line-height"
299+
"--mod-button-line-height",
300+
"--mod-popover-animation-distance"
306301
],
307302
"high-contrast": [
308303
"--highcontrast-picker-background-color",

components/picker/index.css

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,6 @@
102102
--spectrum-picker-focus-indicator-gap: var(--spectrum-focus-indicator-gap);
103103
--spectrum-picker-focus-indicator-thickness: var(--spectrum-focus-indicator-thickness);
104104
--spectrum-picker-focus-indicator-color: var(--spectrum-focus-indicator-color);
105-
106-
& + .spectrum-Popover--bottom-start.is-open {
107-
--spectrum-picker-spacing-picker-to-popover: var(--spectrum-component-to-menu-medium);
108-
}
109105
}
110106

111107
.spectrum-Picker--sizeS {
@@ -124,10 +120,6 @@
124120
--spectrum-picker-spacing-top-to-progress-circle: var(--spectrum-field-top-to-progress-circle-small);
125121
--spectrum-picker-spacing-top-to-disclosure-icon: var(--spectrum-field-top-to-disclosure-icon-75);
126122
--spectrum-picker-spacing-edge-to-disclosure-icon: var(--spectrum-field-end-edge-to-disclosure-icon-75);
127-
128-
& + .spectrum-Popover--bottom-start.is-open {
129-
--spectrum-picker-spacing-picker-to-popover: var(--spectrum-component-to-menu-small);
130-
}
131123
}
132124

133125
.spectrum-Picker--sizeL {
@@ -146,10 +138,6 @@
146138
--spectrum-picker-spacing-top-to-progress-circle: var(--spectrum-field-top-to-progress-circle-large);
147139
--spectrum-picker-spacing-top-to-disclosure-icon: var(--spectrum-field-top-to-disclosure-icon-200);
148140
--spectrum-picker-spacing-edge-to-disclosure-icon: var(--spectrum-field-end-edge-to-disclosure-icon-200);
149-
150-
& + .spectrum-Popover--bottom-start.is-open {
151-
--spectrum-picker-spacing-picker-to-popover: var(--spectrum-component-to-menu-large);
152-
}
153141
}
154142

155143
.spectrum-Picker--sizeXL {
@@ -168,10 +156,7 @@
168156
--spectrum-picker-spacing-top-to-progress-circle: var(--spectrum-field-top-to-progress-circle-extra-large);
169157
--spectrum-picker-spacing-top-to-disclosure-icon: var(--spectrum-field-top-to-disclosure-icon-300);
170158
--spectrum-picker-spacing-edge-to-disclosure-icon: var(--spectrum-field-end-edge-to-disclosure-icon-300);
171-
172-
& + .spectrum-Popover--bottom-start.is-open {
173-
--spectrum-picker-spacing-picker-to-popover: var(--spectrum-component-to-menu-extra-large);
174-
}
159+
--mod-picker-popover-animation-distance: var(--spectrum-component-to-menu-extra-large);
175160
}
176161

177162
.spectrum-Picker--quiet {
@@ -410,8 +395,8 @@
410395
margin-inline-end: var(--mod-picker-spacing-icon-to-disclosure-icon, var(--spectrum-picker-spacing-icon-to-disclosure-icon));
411396
}
412397

413-
.spectrum-Picker + .spectrum-Popover--bottom-start.is-open {
414-
transform: translateY(var(--mod-picker-spacing-picker-to-popover, var(--spectrum-picker-spacing-picker-to-popover)));
398+
.spectrum-Picker-popover {
399+
--mod-popover-animation-distance: var(--mod-picker-popover-animation-distance, var(--spectrum-component-to-menu-medium));
415400
}
416401

417402
.spectrum-Picker--quiet {

components/picker/stories/template.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ export const Template = ({
176176
content: popoverContent,
177177
size,
178178
customStyles: customPopoverStyles,
179+
customClasses: [`${rootClass}-popover`],
179180
popoverWrapperStyles: {
180181
"display": "block",
181182
},
@@ -189,6 +190,13 @@ export const Template = ({
189190
isDisabled,
190191
}, context) : "";
191192

193+
const sizeMap = {
194+
s: "small",
195+
m: "medium",
196+
l: "large",
197+
xl: "extra-large",
198+
};
199+
192200
const markup = html`
193201
<div
194202
style=${styleMap({
@@ -197,7 +205,8 @@ export const Template = ({
197205
...(labelPosition == "side") && {
198206
display: "flex",
199207
flexWrap: "nowrap",
200-
}
208+
},
209+
"--mod-picker-popover-animation-distance": `var(--spectrum-component-to-menu-${sizeMap[size] || "medium" })`,
201210
})}
202211
>
203212
${when(label, () =>

0 commit comments

Comments
 (0)