Skip to content

Commit 1545c67

Browse files
adixon-adobeWestbrook
authored andcommitted
chore: add some coverage on value-separator
1 parent 5dc1e0a commit 1545c67

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

packages/menu/test/menu-group.test.ts

+9-4
Original file line numberDiff line numberDiff line change
@@ -237,15 +237,15 @@ describe('Menu group', () => {
237237
it('handles changing managed items for selects changes', async () => {
238238
const el = await fixture<Menu>(
239239
html`
240-
<sp-menu selects="multiple">
240+
<sp-menu selects="multiple" value-separator="--">
241241
<sp-menu-item selected>First</sp-menu-item>
242242
<sp-menu-item>Second</sp-menu-item>
243243
<sp-menu-group id="mg-inherit">
244244
<sp-menu-item>Inherit1</sp-menu-item>
245245
<sp-menu-item>Inherit2</sp-menu-item>
246246
<sp-menu-group id="mg-sub-inherit">
247247
<sp-menu-item>SubInherit1</sp-menu-item>
248-
<sp-menu-item>SubInherit2</sp-menu-item>
248+
<sp-menu-item selected>SubInherit2</sp-menu-item>
249249
</sp-menu-group>
250250
</sp-menu-group>
251251
</sp-menu>
@@ -257,8 +257,8 @@ describe('Menu group', () => {
257257
'expected outer menu to manage 6 items'
258258
);
259259
await waitUntil(
260-
() => el.selectedItems.length == 1,
261-
'expected 1 selected item'
260+
() => el.selectedItems.length == 2,
261+
'expected 2 selected item'
262262
);
263263
await elementUpdated(el);
264264

@@ -290,6 +290,8 @@ describe('Menu group', () => {
290290
expect(subInheritItem2.getAttribute('role')).to.equal(
291291
'menuitemcheckbox'
292292
);
293+
expect(el.value).to.equal('First--SubInherit2');
294+
expect(el.selectedItems.length).to.equal(2);
293295

294296
inheritGroup.setAttribute('selects', 'single');
295297

@@ -309,5 +311,8 @@ describe('Menu group', () => {
309311
expect(inheritItem2.getAttribute('role')).to.equal('menuitemradio');
310312
expect(subInheritItem1.getAttribute('role')).to.equal('menuitemradio');
311313
expect(subInheritItem2.getAttribute('role')).to.equal('menuitemradio');
314+
expect(el.value).to.equal('First');
315+
//expect(inheritGroup.value).to.equal('SubInherit2')
316+
expect(inheritGroup.selectedItems.length).to.equal(1);
312317
});
313318
});

0 commit comments

Comments
 (0)