Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: sp-dialog: add property to skip auto scrolling #5058

Open
1 task done
spdev3000 opened this issue Jan 31, 2025 · 1 comment
Open
1 task done

[Feat]: sp-dialog: add property to skip auto scrolling #5058

spdev3000 opened this issue Jan 31, 2025 · 1 comment
Labels
Component: Dialog enhancement New feature or request jira ticket created triage An issue needing triage

Comments

@spdev3000
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Dialog

Description of the requested feature

As we sometimes use dialogs with "internal" scrolling, such as settings dialog with a side nav on the left and a content area on the right, we take care of the content scrolling itself.
But currently it's setup in AlertDialog.shouldManageTabOrderForScrolling() that it adds: overflow: auto; automatically based on offsetHeight < scrollHeight, see:

public shouldManageTabOrderForScrolling = (): void => {

We'd like to have a property/attribute like skipAutoScrolling or similar that prevents such feature and "preserves" the css value:

.content {
    overflow: hidden;
}

Mockups or screenshots

Image

Implementation notes or ideas

No response

@najikahalsema
Copy link
Collaborator

SWC-670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Dialog enhancement New feature or request jira ticket created triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

2 participants