Refactor API request parameters in account and market data classes

Author: adradr

lmax_python_sdk/account/account_data.py

@@ -247,7 +247,7 @@ def get_working_orders(
         """
         endpoint = "/v1/account/working-orders"
         params = {"page_size": page_size, "after": after, "before": before}
-        return self._request(endpoint, method="GET", payload=params, authenticated=True)
+        return self._request(endpoint, method="GET", params=params, authenticated=True)
 
     @validate_page_size
     @validate_after_before
@@ -303,7 +303,7 @@ def get_order_positions(
         """
         endpoint = "/v1/account/order-positions"
         params = {"page_size": page_size, "after": after, "before": before}
-        return self._request(endpoint, method="GET", payload=params, authenticated=True)
+        return self._request(endpoint, method="GET", params=params, authenticated=True)
 
     def get_instrument_positions(
         self,
@@ -470,7 +470,7 @@ def get_transactions(
             "before": before,
             "transaction_categories": transaction_categories,
         }
-        return self._request(endpoint, method="GET", payload=params, authenticated=True)
+        return self._request(endpoint, method="GET", params=params, authenticated=True)
 
     @validate_start_end_time
     @validate_page_size
@@ -560,4 +560,4 @@ def get_trade_history(
             "before": before,
             "order_information": order_information,
         }
-        return self._request(endpoint, method="GET", payload=params, authenticated=True)
+        return self._request(endpoint, method="GET", params=params, authenticated=True)

lmax_python_sdk/broker_market_data/market_data.py

@@ -43,7 +43,7 @@ def get_orderbook_snapshot(
         """
         endpoint = f"/v1/marketdata/{instrument_id}"
         params = {"depth": depth}
-        return self._request(endpoint, payload=params, authenticated=True)
+        return self._request(endpoint, params=params, authenticated=True)
 
     def historic_closing_prices(
         self,
@@ -98,4 +98,4 @@ def historic_closing_prices(
         if end_date:
             payload["end_date"] = end_date
 
-        return self._request(endpoint, payload=payload, authenticated=True)
+        return self._request(endpoint, params=payload, authenticated=True)

lmax_python_sdk/client.py

@@ -114,6 +114,7 @@ def _request(
         self,
         endpoint: str,
         method="GET",
+        params: typing.Dict[str, str] = None,
         payload: typing.Dict[str, str] = None,
         authenticated: bool = False,
     ) -> typing.Dict[str, typing.Any]:
@@ -140,6 +141,7 @@ def _request(
         response = requests.request(
             method,
             self.base_url + endpoint,
+            params=params if params else None,
             data=json.dumps(payload) if payload else None,
             headers=headers,
             timeout=5,
@@ -160,6 +162,7 @@ def _request(
             response = requests.request(  # Retry the request with the new token
                 method,
                 self.base_url + endpoint,
+                params=params if params else None,
                 data=json.dumps(payload) if payload else None,
                 headers=headers,
                 timeout=5,