Skip to content

Commit 02389b1

Browse files
authored
Use package http (dnfield#234)
* Use package http * delete test
1 parent 5bc6a02 commit 02389b1

File tree

11 files changed

+27
-94
lines changed

11 files changed

+27
-94
lines changed

packages/vector_graphics/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## 1.1.11
4+
5+
- Use package:http to drop dependency on dart:html.
6+
37
## 1.1.10+1
48

59
- Add missing save before clip.

packages/vector_graphics/lib/src/_http_io.dart

-24
This file was deleted.

packages/vector_graphics/lib/src/_http_web.dart

-21
This file was deleted.

packages/vector_graphics/lib/src/http.dart

-5
This file was deleted.

packages/vector_graphics/lib/src/loader.dart

+7-4
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
import 'package:flutter/services.dart';
66
import 'package:flutter/widgets.dart';
7-
8-
import 'http.dart';
7+
import 'package:http/http.dart' as http;
98

109
/// An interface that can be implemented to support decoding vector graphic
1110
/// binary assets from different byte sources.
@@ -145,17 +144,21 @@ class NetworkBytesLoader extends BytesLoader {
145144
const NetworkBytesLoader(
146145
this.url, {
147146
this.headers,
148-
});
147+
http.Client? httpClient,
148+
}) : _httpClient = httpClient;
149149

150150
/// The HTTP headers to use for the network request.
151151
final Map<String, String>? headers;
152152

153153
/// The [Uri] of the resource to request.
154154
final Uri url;
155155

156+
final http.Client? _httpClient;
157+
156158
@override
157159
Future<ByteData> loadBytes(BuildContext? context) async {
158-
final Uint8List bytes = await httpGet(url, headers: headers);
160+
final http.Client client = _httpClient ?? http.Client();
161+
final Uint8List bytes = (await client.get(url, headers: headers)).bodyBytes;
159162
return bytes.buffer.asByteData();
160163
}
161164

packages/vector_graphics/pubspec.yaml

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: vector_graphics
22
description: A vector graphics rendering package for Flutter.
3-
version: 1.1.10+1
3+
version: 1.1.11
44
homepage: https://github.com/dnfield/vector_graphics
55

66
environment:
@@ -10,13 +10,14 @@ environment:
1010
dependencies:
1111
flutter:
1212
sdk: flutter
13-
vector_graphics_codec: 1.1.10+1
13+
http: ^1.2.1
14+
vector_graphics_codec: 1.1.11
1415

1516
dev_dependencies:
1617
flutter_test:
1718
sdk: flutter
1819
flutter_lints: ^1.0.0
19-
vector_graphics_compiler: 1.1.10+1
20+
vector_graphics_compiler: 1.1.11
2021

2122
# Comment out before publishing
2223
dependency_overrides:

packages/vector_graphics/test/vector_graphics_test.dart

-33
Original file line numberDiff line numberDiff line change
@@ -502,39 +502,6 @@ void main() {
502502
expect(exception.toString(), contains(loader.toString()));
503503
});
504504

505-
testWidgets(
506-
'(WebOnly) creates OpacityLayer, TransformLayer, and ColorFilterLayer to draw picture',
507-
(WidgetTester tester) async {
508-
final TestAssetBundle testBundle = TestAssetBundle();
509-
510-
await tester.pumpWidget(
511-
DefaultAssetBundle(
512-
bundle: testBundle,
513-
child: const Directionality(
514-
textDirection: TextDirection.ltr,
515-
child: VectorGraphic(
516-
loader: AssetBytesLoader('foo.svg'),
517-
colorFilter: ColorFilter.mode(Colors.red, BlendMode.srcIn),
518-
opacity: AlwaysStoppedAnimation<double>(0.5),
519-
),
520-
),
521-
),
522-
);
523-
await tester.pumpAndSettle();
524-
525-
expect(tester.layers.last, isA<PictureLayer>());
526-
expect(
527-
tester.layers[tester.layers.length - 2],
528-
isA<ColorFilterLayer>().having(
529-
(ColorFilterLayer layer) => layer.colorFilter,
530-
'colorFilter',
531-
const ColorFilter.mode(Colors.red, BlendMode.srcIn)));
532-
expect(
533-
tester.layers[tester.layers.length - 3],
534-
isA<OpacityLayer>()
535-
.having((OpacityLayer layer) => layer.alpha, 'alpha', 128));
536-
}, skip: !kIsWeb);
537-
538505
testWidgets(
539506
'Construct vector graphic with drawPicture strategy',
540507
(WidgetTester tester) async {

packages/vector_graphics_codec/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## 1.1.11
4+
5+
- Use package:http to drop dependency on dart:html.
6+
37
## 1.1.10+1
48

59
- Add missing save before clip.

packages/vector_graphics_codec/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: vector_graphics_codec
22
description: An encoding library for `package:vector_graphics`
3-
version: 1.1.10+1
3+
version: 1.1.11
44
homepage: https://github.com/dnfield/vector_graphics
55

66
environment:

packages/vector_graphics_compiler/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CHANGELOG
22

3+
## 1.1.11
4+
5+
- Use package:http to drop dependency on dart:html.
6+
37
## 1.1.10+1
48

59
- Add missing save before clip.

packages/vector_graphics_compiler/pubspec.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: vector_graphics_compiler
22
description: A compiler for `package:vector_graphics`.
3-
version: 1.1.10+1
3+
version: 1.1.11
44
homepage: https://github.com/dnfield/vector_graphics
55

66
executables:
@@ -14,7 +14,7 @@ dependencies:
1414
meta: ^1.7.0
1515
path_parsing: ^1.0.1
1616
xml: ^6.3.0
17-
vector_graphics_codec: 1.1.10+1
17+
vector_graphics_codec: 1.1.11
1818
path: ^1.8.0
1919

2020
dev_dependencies:
@@ -25,7 +25,7 @@ dev_dependencies:
2525
sdk: flutter
2626
flutter_test:
2727
sdk: flutter
28-
vector_graphics: 1.1.10+1
28+
vector_graphics: 1.1.11
2929

3030
# Comment out before publishing
3131
dependency_overrides:

0 commit comments

Comments
 (0)