Skip to content

Conversation

@Nithurshen
Copy link
Contributor

Reference Issues/PRs

Fixes #2854

What does this implement/fix? Explain your changes.

This PR optimizes the _fit method in the ElasticEnsemble classifier to eliminate a redundant cross-validation step, speeding up the fitting process under specific conditions.

Problem

The original implementation first used GridSearchCV or RandomizedSearchCV to find the best parameters for a given distance measure. Then, to get the accuracy score for weighting the ensemble, it performed a second, separate cross_val_predict using those best parameters.

This second cross_val_predict step was redundant when the initial parameter search was already performed on the entire training set (proportion_train_in_param_finding == 1.0), as it was essentially re-running the same validation.

Solution

I've introduced a new logic path that runs only when self.proportion_train_in_param_finding == 1.0 and not self.majority_vote.

The modification:

  1. Bypasses GridSearchCV/RandomizedSearchCV entirely.
  2. Manually iterates through the parameter grid (respecting self.proportion_of_param_options to mimic the randomized search behavior).
  3. Runs cross_val_predict once for each parameter set inside a single loop, calculating the accuracy.
  4. Keeps track of the best accuracy score and the corresponding best parameters as it iterates.

This change combines the parameter search and the accuracy-for-weighting calculation into a single loop, completely removing the redundant N-fold cross-validation pass.

The original logic (using GridSearchCV + the second cross_val_predict) is fully preserved for all other cases (i.e., when subsampling for parameter finding or when majority_vote is True), ensuring no existing behavior is broken.

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance. ##### For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added classification Classification package enhancement New feature, improvement request or other non-bug code enhancement labels Nov 16, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ enhancement ].
I have added the following labels to this PR based on the changes made: [ classification ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

classification Classification package enhancement New feature, improvement request or other non-bug code enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Implement optimisation to ElasticEnsemble grid search

1 participant