Merge pull request #333 from agiledigital/more-specific-policy

Make the queue policy more specific

Author: Sean Dawson

lib/serverless-sns-sqs-lambda.ts

@@ -159,9 +159,8 @@ export default class ServerlessSnsSqsLambda {
     }
 
     this.hooks = {
-      "aws:package:finalize:mergeCustomProviderResources": this.modifyTemplate.bind(
-        this
-      )
+      "aws:package:finalize:mergeCustomProviderResources":
+        this.modifyTemplate.bind(this)
     };
   }
 
@@ -173,8 +172,8 @@ export default class ServerlessSnsSqsLambda {
   modifyTemplate() {
     const functions = this.serverless.service.functions;
     const stage = this.serverless.service.provider.stage;
-    const template = this.serverless.service.provider
-      .compiledCloudFormationTemplate;
+    const template =
+      this.serverless.service.provider.compiledCloudFormationTemplate;
 
     Object.keys(functions).forEach(funcKey => {
       const func = functions[funcKey];
@@ -455,7 +454,7 @@ Usage
             {
               Sid: `${prefix}${name}Sid`,
               Effect: "Allow",
-              Principal: { AWS: "*" },
+              Principal: { Service: "sns.amazonaws.com" },
               Action: "SQS:SendMessage",
               Resource: { "Fn::GetAtt": [`${name}Queue`, "Arn"] },
               Condition: { ArnEquals: { "aws:SourceArn": [topicArn] } }

package.json

@@ -5,6 +5,7 @@
   "main": "dist/index.js",
   "scripts": {
     "test": "eslint lib/**/*.ts && jest --clearCache lib && jest --runInBand lib",
+    "format": "prettier --write 'lib/**/*.{ts,tsx,yaml,yml,js,json}'",
     "build": "tsc",
     "commit": "git-cz",
     "prepack": "tsc"