Skip to content

Commit 279ebfd

Browse files
authored
Merge pull request #1031 from Nothing4You/reference-gha-artifacts-by-id
Reference build artifact by id instead of name in GHA CI/CD workflow
2 parents 39da4a2 + bec46e2 commit 279ebfd

File tree

1 file changed

+18
-13
lines changed

1 file changed

+18
-13
lines changed

.github/workflows/ci-cd.yml

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ jobs:
4646
run:
4747
shell: python
4848
outputs:
49-
dists-artifact-name: python-package-distributions
5049
dist-version: >-
5150
${{
5251
steps.request-check.outputs.release-requested == 'true'
@@ -195,6 +194,9 @@ jobs:
195194

196195
runs-on: ubuntu-latest
197196

197+
outputs:
198+
dists-artifact-id: ${{ steps.dist-artifact-upload.outputs.artifact-id }}
199+
198200
env:
199201
PY_COLORS: 1
200202

@@ -256,10 +258,10 @@ jobs:
256258
'dist/${{ needs.pre-setup.outputs.sdist-artifact-name }}'
257259
'dist/${{ needs.pre-setup.outputs.wheel-artifact-name }}'
258260
- name: Store the distribution packages
261+
id: dist-artifact-upload
259262
uses: actions/upload-artifact@v4
260263
with:
261-
name: >-
262-
${{ needs.pre-setup.outputs.dists-artifact-name }}
264+
name: python-package-distributions
263265
# NOTE: Exact expected file names are specified here
264266
# NOTE: as a safety measure — if anything weird ends
265267
# NOTE: up being in this dir or not all dists will be
@@ -306,8 +308,8 @@ jobs:
306308
- name: Download all the dists
307309
uses: actions/download-artifact@v5
308310
with:
309-
name: >-
310-
${{ needs.pre-setup.outputs.dists-artifact-name }}
311+
artifact-ids: >-
312+
${{ needs.build.outputs.dists-artifact-id }}
311313
path: dist/
312314

313315
- name: Install build tools
@@ -426,8 +428,8 @@ jobs:
426428
- name: Download all the dists
427429
uses: actions/download-artifact@v5
428430
with:
429-
name: >-
430-
${{ needs.pre-setup.outputs.dists-artifact-name }}
431+
artifact-ids: >-
432+
${{ needs.build.outputs.dists-artifact-id }}
431433
path: dist/
432434

433435
- name: Install dependencies
@@ -572,6 +574,7 @@ jobs:
572574
name: Publish 🐍📦 ${{ needs.pre-setup.outputs.git-tag }} to PyPI
573575
needs:
574576
- check
577+
- build
575578
- pre-setup # transitive, for accessing settings
576579
if: >-
577580
fromJSON(needs.pre-setup.outputs.release-requested)
@@ -591,8 +594,8 @@ jobs:
591594
- name: Download all the dists
592595
uses: actions/download-artifact@v5
593596
with:
594-
name: >-
595-
${{ needs.pre-setup.outputs.dists-artifact-name }}
597+
artifact-ids: >-
598+
${{ needs.build.outputs.dists-artifact-id }}
596599
path: dist/
597600
- name: >-
598601
Publish 🐍📦 ${{ needs.pre-setup.outputs.git-tag }} to PyPI
@@ -604,6 +607,7 @@ jobs:
604607
name: Publish 🐍📦 ${{ needs.pre-setup.outputs.git-tag }} to TestPyPI
605608
needs:
606609
- check
610+
- build
607611
- pre-setup # transitive, for accessing settings
608612
if: >-
609613
fromJSON(needs.pre-setup.outputs.is-untagged-devel)
@@ -624,8 +628,8 @@ jobs:
624628
- name: Download all the dists
625629
uses: actions/download-artifact@v5
626630
with:
627-
name: >-
628-
${{ needs.pre-setup.outputs.dists-artifact-name }}
631+
artifact-ids: >-
632+
${{ needs.build.outputs.dists-artifact-id }}
629633
path: dist/
630634
- name: >-
631635
Publish 🐍📦 ${{ needs.pre-setup.outputs.git-tag }} to TestPyPI
@@ -673,6 +677,7 @@ jobs:
673677
${{ needs.pre-setup.outputs.git-tag }}
674678
needs:
675679
- post-release-repo-update
680+
- build
676681
- pre-setup # transitive, for accessing settings
677682
runs-on: ubuntu-latest
678683

@@ -690,8 +695,8 @@ jobs:
690695
- name: Download all the dists
691696
uses: actions/download-artifact@v5
692697
with:
693-
name: >-
694-
${{ needs.pre-setup.outputs.dists-artifact-name }}
698+
artifact-ids: >-
699+
${{ needs.build.outputs.dists-artifact-id }}
695700
path: dist/
696701

697702
- name: >-

0 commit comments

Comments
 (0)