Delete the vestigial github-app-id input (#117)

#93 moved the token action to the client ID. The old input survived as a
fallback for callers that no longer exist, and the generated caller has
never passed it.

It also invites the wrong credential. The name says App ID, which is the
numeric value on the App settings page, but create-github-app-token needs
the Iv23 client ID. An adopter reading the input list had a documented
reason to supply the wrong one.

CHANGELOG entries are left alone. They record what shipped in past
releases and are not instructions.

Closes #116

Author: charlesgreen

.github/workflows/simplycubed.yml

@@ -13,12 +13,6 @@ on:
         default: ""
         required: false
         type: string
-      github-app-id:
-        description: Deprecated, kept so an existing caller keeps working. Pass
-          github-app-client-id instead.
-        default: ""
-        required: false
-        type: string
       issue-number:
         description: Issue number to run, when triggered from issues:labeled.
         default: ""
@@ -80,7 +74,7 @@ jobs:
         id: app-token
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
         with:
-          client-id: ${{ inputs['github-app-client-id'] || inputs['github-app-id'] }}
+          client-id: ${{ inputs['github-app-client-id'] }}
           private-key: ${{ secrets['github-app-private-key'] }}
           owner: ${{ steps.repo.outputs.owner }}
           repositories: ${{ steps.repo.outputs.name }}
@@ -168,7 +162,7 @@ jobs:
         id: app-token
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
         with:
-          client-id: ${{ inputs['github-app-client-id'] || inputs['github-app-id'] }}
+          client-id: ${{ inputs['github-app-client-id'] }}
           private-key: ${{ secrets['github-app-private-key'] }}
           owner: ${{ steps.repo.outputs.owner }}
           repositories: ${{ steps.repo.outputs.name }}