Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor mistake in quickstart guide #90

Open
ReswanR opened this issue Aug 20, 2024 · 1 comment
Open

Minor mistake in quickstart guide #90

ReswanR opened this issue Aug 20, 2024 · 1 comment

Comments

@ReswanR
Copy link

ReswanR commented Aug 20, 2024

I think I discovered a small mistake in the quickstart guide at this section:

https://pcse.readthedocs.io/en/stable/user_guide.html#site-parameters

Currently the quickstart guide calls the WOFOST72SiteDataProvider from the util;

"from pcse.util import WOFOST72SiteDataProvider"

in the current version of pcse, the SiteDataProviders are located under pcse.input and not in the pcse.util.

Moreover, in the next line of the guide the input parameters "WAV" and "CO2" are given, but WOFOST72SiteDataProvider does not accept CO2 input. Perhaps this should instead refer to WOFOST73SiteDataProvider, which does accept CO2?

The resulting SMLIM obtained from WOFOST73SiteDataProvider is correct with the current example.

Below is a screenshot of the relevant section.

image

@ReswanR ReswanR changed the title Minor mistake in documentation Minor mistake in quickstart guide Aug 20, 2024
@ajwdewit
Copy link
Owner

Thanks, I will update it in the user guide and it will get fixed in the next PCSE minor upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants