Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the FediPress plugin is activated the edit post link does not work #456

Open
amelciaao opened this issue Feb 4, 2025 · 9 comments
Open

Comments

@amelciaao
Copy link

As in the title. When the FediPress plugin is active it is not possible to edit posts because the “edit post” link redirects to the post on the frontend. I don't see any errors in the logs from the Frends plug-in series.

@jeherve
Copy link
Contributor

jeherve commented Feb 5, 2025

Is this the "edit post" link you had in mind, in the WordPress admin bar?

Image

I assume the FediPress plugin you use on your site is this one?
https://github.com/alquimidia/fedipress

@amelciaao
Copy link
Author

amelciaao commented Feb 5, 2025

Yes, I use the plugin from this link. The non-working button is available in two places: the admin bar - your screenshot and next to each post item - the highlighted item in the screenshot.
Glossary: wpisy - posts

Image

P.S. Sory I have the Polish language set. I hope this is not a problem.

@akirk
Copy link
Owner

akirk commented Feb 6, 2025

Thanks for explaining, where does the link go exactly? to a /friends/1234/ like URL?

@amelciaao
Copy link
Author

No. The link goes to /category/slug-post.

@akirk
Copy link
Owner

akirk commented Feb 7, 2025

I can't see a clear reason why this should be caused by the FediPress theme plugin. Can you confirm that the links work again if you deactivate FediPress (but keep the Friends plugin)?

@amelciaao
Copy link
Author

Yes, I confirm that with FediPress disabled and the Friends plugin enabled, everything works fine. I disabled all other plugins to make sure that there are no interactions between all plugins.

I myself do not see a correlation of the bug with the FediPress code. Need some information on WP configuration, debug.log (Friends and FediPress do not report any error, warning)?

@liviacarolgouvea
Copy link
Contributor

Hi @amelciaao and @jeherve
I solved this problem in the V1.0.2 Fedpress version.
I'll send a PR to Friends plugins.json ok, @akirk ?

@akirk
Copy link
Owner

akirk commented Feb 13, 2025

Oh, great find, @liviacarolgouvea . I've merged the PR. The fix that you made seems I should rather make inside the Friends plugin. I just still cannot reproduce it or understand why your fix helps, do you have further steps to reproduce?

@liviacarolgouvea
Copy link
Contributor

Hi @akirk

The Fedpress friends_frontend_post_types filter is used to display blog posts on friends' timeline.

Before this commit, the filter was impacting the edition of other pages. This condition is therefore added to apply only to the Friends page.

It was a problem with the Fedipress plugin, I think there is no need to correct it in Friends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants