Skip to content

Commit 57f62fb

Browse files
committed
Clarified that weewx supports FTPS, not SFTP.
1 parent 054b3b4 commit 57f62fb

File tree

7 files changed

+10
-8
lines changed

7 files changed

+10
-8
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
<li>Support for multiple skins</li>
8282
<li>Support sqlite and MySQL</li>
8383
<li>Optional uploads to Weather Underground, CWOP, AWEKAS, WOW, and others</li>
84-
<li>Uploads to your website via FTP, SFTP, or rsync</li>
84+
<li>Uploads to your website via FTP, FTPS, or rsync</li>
8585
<li>Extensive almanac information</li>
8686
</ul>
8787

bin/weecfg/test/expected/weewx32_expected.conf

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ version = 3.2.0
142142
#server = replace with your server name, e.g, www.threefools.org
143143
#path = replace with the destination directory (e.g., /weather)
144144

145-
# Set to True for a secure FTP (SFTP) connection. Not all servers
145+
# Set to True for an FTP over TLS (FTPS) connection. Not all servers
146146
# support this:
147147
secure_ftp = False
148148

bin/weecfg/test/expected/weewx_user_expected.conf

+1-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ version = 3.2.0a2
202202
#server = replace with the ftp server name, e.g, www.threefools.org
203203
#path = replace with the ftp destination directory (e.g., /weather)
204204

205-
# Set to True for a secure FTP (SFTP) connection. Not all servers
205+
# Set to True for an FTP over TLS (FTPS) connection. Not all servers
206206
# support this.
207207
secure_ftp = False
208208

bin/weeutil/ftpupload.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def __init__(self, server,
4747
max_tries: How many times to try creating a directory or uploading
4848
a file before giving up [Optional. Default is 3]
4949
50-
secure: Set to True to attempt a secure FTP (SFTP) session.
50+
secure: Set to True to attempt an FTP over TLS (FTPS) session.
5151
5252
debug: Set to 1 for extra debug information, 0 otherwise.
5353
"""
@@ -73,7 +73,7 @@ def run(self):
7373
FTPClass = ftplib.FTP_TLS
7474
except AttributeError:
7575
FTPClass = ftplib.FTP
76-
syslog.syslog(syslog.LOG_DEBUG, "ftpupload: Your version of Python does not support SFTP. Using unsecure connection.")
76+
syslog.syslog(syslog.LOG_DEBUG, "ftpupload: Your version of Python does not support FTPS. Using insecure connection.")
7777
self.secure = False
7878
else:
7979
FTPClass = ftplib.FTP

docs/changes.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ Fixes ticket #40.
408408
Fixed problem where dumping to database could cause stats to get added to
409409
the daily summaries twice.
410410

411-
Secure FTP (SFTP) sessions are now possible, but don't work very well with
411+
FTP over TLS (FTPS) sessions are now possible, but don't work very well with
412412
Microsoft FTP servers. Requires Python v2.7. Will not work with older
413413
versions of Python. Fixes ticket #37.
414414

docs/usersguide.htm

+3-1
Original file line numberDiff line numberDiff line change
@@ -2452,7 +2452,9 @@ <h3 class="config_section">[[FTP]]</h3>
24522452

24532453
<p class="config_important">secure_ftp</p>
24542454

2455-
<p>Set to <span class="code">True</span> to use a secure FTP (SFTP) connection. Not
2455+
<p>Set to <span class="code">True</span> to use FTP (FTPS) over TLS. This is an extension to the FTP
2456+
protocol that uses a Secure Socket Layer (SSL) protocol, <em>not</em> to be confused with
2457+
SFTP, which uses a Secure Socket Shell protocol. Not
24562458
all FTP servers support this. In particular, the Microsoft FTP server seems to do a poor
24572459
job of it. Requires Python V2.7. Will not work with older versions of Python.
24582460
Optional. Default is <span class="code">False</span></p>

weewx.conf

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ version = 3.5.0
150150
#server = replace with the ftp server name, e.g, www.threefools.org
151151
#path = replace with the ftp destination directory (e.g., /weather)
152152

153-
# Set to True for a secure FTP (SFTP) connection. Not all servers
153+
# Set to True for an FTP over TLS (FTPS) connection. Not all servers
154154
# support this.
155155
secure_ftp = False
156156

0 commit comments

Comments
 (0)