Skip to content

Commit 9737bc6

Browse files
committed
Fix incorrect type in ManifestRegistrar#finalize!
`#finalize!` is sending the basename directly to `#call`, which expects a Dry::System::Identifier. This means that if you configure a `registrations_dir`, putting any file in that directory will lead to an exception during finalization. This appears to have been introduced during dry-rb#208
1 parent 1c5e3ae commit 9737bc6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/dry/system/manifest_registrar.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def initialize(container)
2727
# @api private
2828
def finalize!
2929
::Dir[registrations_dir.join(RB_GLOB)].sort.each do |file|
30-
call(File.basename(file, RB_EXT))
30+
call(Identifier.new(File.basename(file, RB_EXT)))
3131
end
3232
end
3333

0 commit comments

Comments
 (0)