Skip to content

Commit 48c8323

Browse files
authored
Fix response interceptor keyword argument (#92)
Fixes #91.
1 parent 928027f commit 48c8323

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

ask-sdk-runtime/ask_sdk_runtime/dispatch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def dispatch(self, handler_input):
119119

120120
for response_interceptor in self.response_interceptors:
121121
response_interceptor.process(
122-
handler_input=handler_input, dispatch_output=output)
122+
handler_input=handler_input, response=output)
123123

124124
return output
125125
except Exception as e:
@@ -186,6 +186,6 @@ def __dispatch_request(self, handler_input):
186186
request_handler_chain.response_interceptors)
187187
for response_interceptor in local_response_interceptors:
188188
response_interceptor.process(
189-
handler_input=handler_input, dispatch_output=output)
189+
handler_input=handler_input, response=output)
190190

191191
return output

ask-sdk-runtime/ask_sdk_runtime/dispatch_components/request_components.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,16 +97,16 @@ class AbstractResponseInterceptor(object):
9797
__metaclass__ = ABCMeta
9898

9999
@abstractmethod
100-
def process(self, handler_input, dispatch_output):
100+
def process(self, handler_input, response):
101101
# type: (Input, Output) -> None
102102
"""Process the input and the output after the Handler is run.
103103
104104
:param handler_input: Generic input passed to the
105105
dispatcher.
106106
:type handler_input: Input
107-
:param dispatch_output: Execution result of the Handler on
107+
:param response: Execution result of the Handler on
108108
dispatch input.
109-
:type dispatch_output: Union[None, Output]
109+
:type response: Union[None, Output]
110110
:rtype: None
111111
"""
112112
raise NotImplementedError

ask-sdk-runtime/tests/unit/test_dispatch.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,14 +301,14 @@ def test_handler_input_successful_local_response_interceptors_execution(self):
301301

302302
test_interceptor_1.process.assert_called_once_with(
303303
handler_input=self.valid_handler_input,
304-
dispatch_output=test_response_before_interceptor), (
304+
response=test_response_before_interceptor), (
305305
"Dispatcher dispatch method didn't process local response "
306306
"interceptors after calling request handler "
307307
"handle")
308308

309309
test_interceptor_2.process.assert_called_once_with(
310310
handler_input=self.valid_handler_input,
311-
dispatch_output=test_response_from_interceptor_1), (
311+
response=test_response_from_interceptor_1), (
312312
"Dispatcher dispatch method didn't process local response "
313313
"interceptors after calling request handler "
314314
"handle")
@@ -350,13 +350,13 @@ def test_handler_input_successful_global_response_interceptors_execution(self):
350350

351351
test_interceptor_1.process.assert_called_once_with(
352352
handler_input=self.valid_handler_input,
353-
dispatch_output=test_response_before_interceptor), (
353+
response=test_response_before_interceptor), (
354354
"Dispatcher dispatch method didn't process global request "
355355
"interceptors after calling dispatch request")
356356

357357
test_interceptor_2.process.assert_called_once_with(
358358
handler_input=self.valid_handler_input,
359-
dispatch_output=test_response_from_interceptor_1), (
359+
response=test_response_from_interceptor_1), (
360360
"Dispatcher dispatch method didn't process global request "
361361
"interceptors after calling dispatch request")
362362

0 commit comments

Comments
 (0)