Skip to content

Commit f6c47bd

Browse files
committed
remove EnvironmentUtils
1 parent b6a07ef commit f6c47bd

File tree

6 files changed

+8
-91
lines changed

6 files changed

+8
-91
lines changed

Diff for: aliyun-java-sdk-core/src/main/java/com/aliyuncs/DefaultAcsClient.java

-1
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,6 @@ private <T extends AcsResponse> HttpResponse doRealAction(AcsRequest<T> request,
319319
String regionId, AlibabaCloudCredentials credentials, Signer signer, FormatType format)
320320
throws ClientException, ServerException {
321321

322-
323322
doActionWithProxy(request.getSysProtocol(), System.getenv("HTTPS_PROXY"), System.getenv("HTTP_PROXY"));
324323
doActionWithIgnoreSSL(request, X509TrustAll.ignoreSSLCerts);
325324

Diff for: aliyun-java-sdk-core/src/main/java/com/aliyuncs/http/clients/ApacheHttpClient.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.aliyuncs.exceptions.ClientException;
44
import com.aliyuncs.http.*;
5-
import com.aliyuncs.utils.EnvironmentUtils;
5+
import com.aliyuncs.utils.EnvHelper;
66
import com.aliyuncs.utils.IOUtils;
77
import com.aliyuncs.utils.StringUtils;
88
import org.apache.http.Header;
@@ -271,16 +271,16 @@ private HttpUriRequest parseToHttpRequest(HttpRequest apiReq) throws IOException
271271
}
272272

273273
private HttpHost calcProxy(HttpRequest apiReq) throws MalformedURLException, ClientException {
274-
boolean needProxy = HttpUtil.needProxy(new URL(apiReq.getSysUrl()).getHost(), clientConfig.getNoProxy(), EnvironmentUtils.getNoProxy());
274+
boolean needProxy = HttpUtil.needProxy(new URL(apiReq.getSysUrl()).getHost(), clientConfig.getNoProxy(), EnvHelper.getenv("NO_PROXY"));
275275
if (!needProxy) {
276276
return null;
277277
}
278278
URL url = new URL(apiReq.getSysUrl());
279279
HttpHost proxy = null;
280280
if ("https".equalsIgnoreCase(url.getProtocol())) {
281-
proxy = HttpUtil.getApacheProxy(clientConfig.getHttpsProxy(), EnvironmentUtils.getHttpsProxy(), apiReq);
281+
proxy = HttpUtil.getApacheProxy(clientConfig.getHttpsProxy(), EnvHelper.getenv("HTTPS_PROXY"), apiReq);
282282
} else {
283-
proxy = HttpUtil.getApacheProxy(clientConfig.getHttpProxy(), EnvironmentUtils.getHttpProxy(), apiReq);
283+
proxy = HttpUtil.getApacheProxy(clientConfig.getHttpProxy(), EnvHelper.getenv("HTTP_PROXY"), apiReq);
284284
}
285285
return proxy;
286286
}

Diff for: aliyun-java-sdk-core/src/main/java/com/aliyuncs/http/clients/CompatibleUrlConnClient.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import com.aliyuncs.exceptions.ClientException;
44
import com.aliyuncs.http.*;
5-
import com.aliyuncs.utils.EnvironmentUtils;
5+
import com.aliyuncs.utils.EnvHelper;
66
import org.apache.http.conn.ssl.DefaultHostnameVerifier;
77
import org.apache.http.conn.ssl.NoopHostnameVerifier;
88

@@ -165,16 +165,16 @@ private void checkHttpRequest(HttpRequest request) {
165165

166166
private Proxy calcProxy(URL url, HttpRequest request) throws ClientException {
167167
String targetHost = url.getHost();
168-
boolean needProxy = HttpUtil.needProxy(targetHost, clientConfig.getNoProxy(), EnvironmentUtils.getNoProxy());
168+
boolean needProxy = HttpUtil.needProxy(targetHost, clientConfig.getNoProxy(), EnvHelper.getenv("NO_PROXY"));
169169
if (!needProxy) {
170170
return Proxy.NO_PROXY;
171171
}
172172
Proxy proxy;
173173
if ("https".equalsIgnoreCase(url.getProtocol())) {
174-
String httpsProxy = EnvironmentUtils.getHttpsProxy();
174+
String httpsProxy = EnvHelper.getenv("HTTPS_PROXY");
175175
proxy = HttpUtil.getJDKProxy(clientConfig.getHttpsProxy(), httpsProxy, request);
176176
} else {
177-
String httpProxy = EnvironmentUtils.getHttpProxy();
177+
String httpProxy = EnvHelper.getenv("HTTP_PROXY");
178178
proxy = HttpUtil.getJDKProxy(clientConfig.getHttpProxy(), httpProxy, request);
179179
}
180180
return proxy;

Diff for: aliyun-java-sdk-core/src/main/java/com/aliyuncs/utils/EnvironmentUtils.java

-48
This file was deleted.

Diff for: aliyun-java-sdk-core/src/test/java/com/aliyuncs/auth/EnvironmentVariableCredentialsProviderTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.aliyuncs.exceptions.ClientException;
44
import com.aliyuncs.utils.AuthUtils;
55
import com.aliyuncs.utils.EnvHelper;
6-
import com.aliyuncs.utils.EnvironmentUtils;
76

87
import org.junit.Assert;
98
import org.junit.Test;

Diff for: aliyun-java-sdk-core/src/test/java/com/aliyuncs/utils/EnvironmentUtilsTest.java

-33
This file was deleted.

0 commit comments

Comments
 (0)