strict-plugin | CR fixes

Author: KostkaBrukowa

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 Jarosław Glegoła Kamil Krysiak
+Copyright (c) 2021 Jarosław Glegoła Kamil Krysiak
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

e2e/fixtures/lang-server.js

@@ -9,10 +9,8 @@ class TSServer {
     this._responseCommandEmitter = new EventEmitter();
     const tsserverPath = require.resolve('typescript/lib/tsserver');
 
-    // to open ts log from tests
-    // process.env['TSS_LOG'] =
-    //   '-logToFile true -file /Users/jaroslaw.glegola/Documents/Praca/typescript-strict-plugin/log1.txt -level
-    //   verbose';
+    // to create ts log from tests
+    // process.env['TSS_LOG'] = '-logToFile true -file /path/typescript-strict-plugin/log1.txt -level verbose';
     const server = fork(tsserverPath, {
       cwd: path.join(__dirname, '../project-fixture/src'),
       stdio: ['pipe', 'pipe', 'pipe', 'ipc'],

package-lock.json

@@ -1,9 +1,12 @@
 {
   "name": "typescript-strict-plugin",
-  "version": "1.0.0-beta.1",
+  "version": "1.0.0-beta.2",
   "description": "https://github.com/Microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin",
   "main": "dist/index.js",
   "private": false,
+  "files": [
+    "dist"
+  ],
   "scripts": {
     "test": "npm run e2e",
     "build": "tsc",
@@ -20,9 +23,6 @@
   ],
   "author": "Sebastián Gurin",
   "license": "MIT",
-  "dependencies": {
-    "typescript": "4.1.3"
-  },
   "devDependencies": {
     "@types/node": "^14.14.35",
     "@typescript-eslint/eslint-plugin": "^4.18.0",
@@ -32,7 +32,8 @@
     "glob": "^7.1.6",
     "husky": "4.3.8",
     "lint-staged": "^10.5.4",
-    "prettier": "^2.2.1"
+    "prettier": "^2.2.1",
+    "typescript": "4.1.3"
   },
   "lint-staged": {
     "*.(js|ts)": [

package.json

@@ -1,6 +1,6 @@
 {
-  "name": "sample-ts-plugin1-sample-project",
-  "version": "1.0.4",
+  "name": "sample-project",
+  "version": "1.0.0",
   "description": "https://github.com/Microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin",
   "main": "index.js",
   "private": true,

sample-project/package.json

@@ -1,9 +1,10 @@
-import { PluginInfo, setupProxy, turnOffStrictMode, turnOnStrictMode } from './utils';
+import { PluginInfo, setupProxy, turnOffStrictMode, turnOnStrictMode, log } from './utils';
 import { StrictFileChecker } from './strictFiles';
 
 const init: ts.server.PluginModuleFactory = () => {
   function create(info: PluginInfo) {
     const proxy = setupProxy(info);
+    log(info, 'Plugin initialized');
 
     proxy.getSemanticDiagnostics = function (fileName) {
       const strictFile = new StrictFileChecker(info).isFileStrict(fileName);

src/index.ts

@@ -11,13 +11,13 @@ export class StrictFileChecker {
   }
 
   public isFileStrict(filePath: string): boolean {
-    const { paths: pathsToTurnOnStrictMode } = this.info.config as Config;
+    const { paths: pathsToTurnOnStrictMode = [] } = this.info.config as Config;
 
     if (this.isTsStrictCommentPresent(filePath)) {
       return true;
     }
 
-    return !!pathsToTurnOnStrictMode?.some((strictPath) => this.isFileOnPath(filePath, strictPath));
+    return pathsToTurnOnStrictMode.some((strictPath) => this.isFileOnPath(filePath, strictPath));
   }
 
   private isFileOnPath(currentFilePath: string, pathToStrictFiles: string) {