Skip to content

Commit d7f7189

Browse files
committed
core, commons: Remove dead code and TODOs
See #300 and #274
1 parent c65b8ea commit d7f7189

File tree

5 files changed

+3
-38
lines changed

5 files changed

+3
-38
lines changed

alpha-commons/src/main/java/at/ac/tuwien/kr/alpha/commons/PredicateImpl.java

-8
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,6 @@ class PredicateImpl implements Predicate {
2424
this.solverInternal = solverInternal;
2525
}
2626

27-
static PredicateImpl getInstance(String symbol, int arity) {
28-
return getInstance(symbol, arity, false, false);
29-
}
30-
31-
static PredicateImpl getInstance(String symbol, int arity, boolean internal) {
32-
return getInstance(symbol, arity, internal, false);
33-
}
34-
3527
static PredicateImpl getInstance(String symbol, int arity, boolean internal, boolean solverInternal) {
3628
return INTERNER.intern(new PredicateImpl(symbol, arity, internal, solverInternal));
3729
}

alpha-commons/src/main/java/at/ac/tuwien/kr/alpha/commons/literals/BasicLiteralImpl.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
*
4545
* Copyright (c) 2017-2018, the Alpha Team.
4646
*/
47-
class BasicLiteralImpl extends AbstractLiteral implements BasicLiteral { // TODO could we parameterize Literal with Atom type?
47+
class BasicLiteralImpl extends AbstractLiteral implements BasicLiteral {
4848

4949
BasicLiteralImpl(BasicAtom atom, boolean positive) {
5050
super(atom, positive);

alpha-core/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ val antlrVersion = "4.7"
88
val stringtemplateVersion = "4.0.8"
99

1010
dependencies {
11-
api(project(":alpha-api")) // TODO does it make more sense to use implementation scope?
12-
api(project(":alpha-commons")) // TODO does it make more sense to use implementation scope?
11+
api(project(":alpha-api"))
12+
api(project(":alpha-commons"))
1313

1414
// We need to give the ANTLR Plugin a hint.
1515
antlr("org.antlr:antlr4:${antlrVersion}")

alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/common/CoreAnswerSet.java

-14
This file was deleted.

alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/common/fixedinterpretations/PredicateInterpretationImpl.java

-13
This file was deleted.

0 commit comments

Comments
 (0)