Accepting PRs

[travisghansen]

I can't tell if this project is totally dead or not. I see several fork with little tweaks/fixes here and there. I have a fix for handling the http timeout error which is otherwise uncatchable and gracefully handing that.

If I start aggregating the various patches/fixes from the forks would they be accepted into this and willing to push a new release?

Thanks!

[alxhotel]

Hi @travisghansen I'll make sure any PRs get reviewed and merged. I'm not personally working on new features, but I'll keep everything working and up to date

I'll review this weekend everything.

Regarding the forks, can you point me to those that have changes worth integrating in this repo?

Also feel free to make any new PRs, I'll make sure to merged them

[travisghansen]

Thanks for shouting back! I have been scouring through them and will send over what I think is relevant.

Biggest issue I have is the timeout error on the http.get (ssdp bits) call which is uncatchable externally and causes the app to crash. I have a fix for that already.

Do you by chance have an eslintrc and prettierrc you can commit? Maybe add those as dev dependencies to keep contributions using consistent formatting? My default vscode setup is completely reformatting the files causing huge diffs for small changes.

[travisghansen]

Is there a particular reason the devices array is an append only situation instead of updating the existing entry/device?

[alxhotel]

That's just a missing feature. I think we should add some logic to remove them once the device is no longer found

[travisghansen]

Ok, I will work it into my changes. Thanks!

[travisghansen]

OK, PR is submitted. I've been running the code in long-running daemon for a few days and everything seems sane thus far. The idempotency and gc logic seems to spot on with my testing so far.