Liquid spec in kilt is broken

[straight-shoota]

I noticed a failure in https://github.com/jeromegn/kilt/blob/master/spec/kilt/liquid_spec.cr. This is a different project which uses liquid.cr, but the error seems to be inside the liquid.cr implementation.
Filed an issue on kilt: jeromegn/kilt#30 but posting here as well because it's not clear where the error comes from.

In lib/liquid/src/liquid/codegen_visitor.cr:58:76

 58 | Liquid::Block::ExpressionNode.new("#{escape node.value.var}")))
                                                             ^--
Error: undefined method 'var' for Liquid::Expression

We're testing kilt in https://github.com/crystal-lang/test-ecosystem and it started to fail somwhere between January 15 and January 22 on master.
It also fails against Crystal 1.15.1 so it does not seem to be a regression in the compiler or stdlib.

[hugopl]

I remember that the code gen on this shard isn't well tested like the part of the code that renders it at runtime. So my bet was that something is missing on code gen after the 1.0.0 that was almost a rewrite.

[hugopl]

I was taking a look on this, the proper fix would be to let the golden tests also run with the code gen, since there is probably more errors on code gen to be fixed.

[hugopl]

I fixed the codegen, BTW the current implementation isn't much faster than parse and render and could be improved a lot, nowadays it just saves the parsing code and all the rest is the same code path with the same memory consumption.

Could you check if #88 fixes the issue?

Thanks.

[straight-shoota]

With #88 I get a different error:

In spec/kilt/liquid_spec.cr:21:22

 21 | ctx.set "process", { "pid" => Process.pid }
                         ^
Error: expected argument #2 to 'Liquid::Context#set' to be (Array(Liquid::Any) | Bool | Float32 | Float64 | Hash(String, Liquid::Any) | Int32 | Int64 | Liquid::Drop | String | Time | Nil) or Liquid::Any, not Hash(String, Int64)

Overloads are:
 - Liquid::Context#set(var : String, value : Any)
 - Liquid::Context#set(var : String, value : Any::Type)

Reproduction with this dep change:

diff --git i/shard.yml w/shard.yml
index b7b6763..01456a3 100644
--- i/shard.yml
+++ w/shard.yml
@@ -15,7 +15,8 @@ development_dependencies:
   temel:
     github: f/temel
   liquid:
-    github: TechMagister/liquid.cr
+    github: reliantsolutions/liquid.cr
+    branch: fix-codegen
   jbuilder:
     github: shootingfly/jbuilder
   water:

[hugopl]

I believe a new release would be welcome after closing this regression.