Coverity high impact fixes (flame#107)

- Re-implemented memory leak fixes overwritten by LAPACKE update.
- Implemented fixes for use of uninitialized variables in extreme cases.

AMD-Internal: CPUPL-6488

Author: Ahmad, Sameer

src/base/flamec/wrappers/lapack/external/FLA_Chol_blk_external.c

@@ -8,6 +8,10 @@
 
 */
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "FLAME.h"
 
 FLA_Error FLA_Chol_blk_external( FLA_Uplo uplo, FLA_Obj A )
@@ -24,6 +28,7 @@ FLA_Error FLA_Chol_blk_external( FLA_Uplo uplo, FLA_Obj A )
 
   if ( FLA_Obj_has_zero_dim( A ) ) return FLA_SUCCESS;
 
+  info = 0;
   datatype = FLA_Obj_datatype( A );
 
   m_A      = FLA_Obj_length( A );

src/base/flamec/wrappers/lapack/external/FLA_Chol_unb_external.c

@@ -8,6 +8,10 @@
 
 */
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "FLAME.h"
 
 FLA_Error FLA_Chol_unb_external( FLA_Uplo uplo, FLA_Obj A )
@@ -24,6 +28,7 @@ FLA_Error FLA_Chol_unb_external( FLA_Uplo uplo, FLA_Obj A )
 
   if ( FLA_Obj_has_zero_dim( A ) ) return FLA_SUCCESS;
 
+  info = 0;
   datatype = FLA_Obj_datatype( A );
 
   m_A      = FLA_Obj_length( A );

src/base/flamec/wrappers/lapack/external/FLA_LU_piv_blk_external.c

@@ -8,6 +8,10 @@
 
 */
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "FLAME.h"
 
 FLA_Error FLA_LU_piv_blk_external( FLA_Obj A, FLA_Obj p )
@@ -23,6 +27,7 @@ FLA_Error FLA_LU_piv_blk_external( FLA_Obj A, FLA_Obj p )
 
   if ( FLA_Obj_has_zero_dim( A ) ) return FLA_SUCCESS;
 
+  info = 0;
   datatype = FLA_Obj_datatype( A );
 
   m_A      = FLA_Obj_length( A );

src/base/flamec/wrappers/lapack/external/FLA_LU_piv_unb_external.c

@@ -8,6 +8,10 @@
 
 */
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "FLAME.h"
 
 FLA_Error FLA_LU_piv_unb_external( FLA_Obj A, FLA_Obj p )
@@ -23,6 +27,7 @@ FLA_Error FLA_LU_piv_unb_external( FLA_Obj A, FLA_Obj p )
 
   if ( FLA_Obj_has_zero_dim( A ) ) return FLA_SUCCESS;
 
+  info = 0;
   datatype = FLA_Obj_datatype( A );
 
   m_A      = FLA_Obj_length( A );

src/base/flamec/wrappers/lapack/external/FLA_Trinv_blk_external.c

@@ -8,6 +8,10 @@
 
 */
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "FLAME.h"
 
 FLA_Error FLA_Trinv_blk_external( FLA_Uplo uplo, FLA_Diag diag, FLA_Obj A )
@@ -25,6 +29,7 @@ FLA_Error FLA_Trinv_blk_external( FLA_Uplo uplo, FLA_Diag diag, FLA_Obj A )
 
   if ( FLA_Obj_has_zero_dim( A ) ) return FLA_SUCCESS;
 
+  info = 0;
   datatype = FLA_Obj_datatype( A );
 
   m_A      = FLA_Obj_length( A );

src/base/flamec/wrappers/lapack/external/FLA_Trinv_unb_external.c

@@ -8,6 +8,10 @@
 
 */
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "FLAME.h"
 
 FLA_Error FLA_Trinv_unb_external( FLA_Uplo uplo, FLA_Diag diag, FLA_Obj A )
@@ -25,6 +29,7 @@ FLA_Error FLA_Trinv_unb_external( FLA_Uplo uplo, FLA_Diag diag, FLA_Obj A )
 
   if ( FLA_Obj_has_zero_dim( A ) ) return FLA_SUCCESS;
 
+  info = 0;
   datatype = FLA_Obj_datatype( A );
 
   m_A      = FLA_Obj_length( A );

src/lapacke/LAPACKE/src/lapacke_cgejsv.c

@@ -30,6 +30,10 @@
 * Author: Intel Corporation
 *****************************************************************************/
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "lapacke_utils.h"
 
 lapack_int API_SUFFIX(LAPACKE_cgejsv)( int matrix_layout, char joba, char jobu, char jobv,
@@ -174,9 +178,9 @@ lapack_int API_SUFFIX(LAPACKE_cgejsv)( int matrix_layout, char joba, char jobu,
         istat[i] = iwork[i];
     }
     /* Release memory and exit */
-    LAPACKE_free( cwork );
-exit_level_2:
     LAPACKE_free( rwork );
+exit_level_2:
+    LAPACKE_free( cwork );
 exit_level_1:
     LAPACKE_free( iwork );
 exit_level_0:

src/lapacke/LAPACKE/src/lapacke_cgesvdq.c

@@ -30,6 +30,10 @@
 * Author: Intel Corporation
 *****************************************************************************/
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "lapacke_utils.h"
 
 lapack_int API_SUFFIX(LAPACKE_cgesvdq)( int matrix_layout, char joba, char jobp,
@@ -80,22 +84,24 @@ lapack_int API_SUFFIX(LAPACKE_cgesvdq)( int matrix_layout, char joba, char jobp,
     cwork = (lapack_complex_float*)LAPACKE_malloc( sizeof(lapack_complex_float) * lcwork );
     if( cwork == NULL ) {
         info = LAPACK_WORK_MEMORY_ERROR;
-        goto exit_level_0;
+        goto exit_level_1;
     }
     rwork = (float*)LAPACKE_malloc( sizeof(float) * lrwork );
     if( rwork == NULL ) {
         info = LAPACK_WORK_MEMORY_ERROR;
-        goto exit_level_0;
+        goto exit_level_2;
     }
     /* Call middle-level interface */
     info = API_SUFFIX(LAPACKE_cgesvdq_work)( matrix_layout, joba, jobp, jobr, jobu, jobv,
                                  m, n, a, lda, s, u, ldu, v, ldv, numrank,
                                  iwork, liwork, cwork, lcwork, rwork, lrwork );
 
     /* Release memory and exit */
-    LAPACKE_free( iwork );
-    LAPACKE_free( cwork );
     LAPACKE_free( rwork );
+exit_level_2:
+    LAPACKE_free( cwork );
+exit_level_1:
+    LAPACKE_free( iwork );
 exit_level_0:
     if( info == LAPACK_WORK_MEMORY_ERROR ) {
         API_SUFFIX(LAPACKE_xerbla)( "LAPACKE_cgesvdq", info );

src/lapacke/LAPACKE/src/lapacke_cgesvdx.c

@@ -30,6 +30,10 @@
 * Author: Intel Corporation
 *****************************************************************************/
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "lapacke_utils.h"
 
 lapack_int API_SUFFIX(LAPACKE_cgesvdx)( int matrix_layout, char jobu, char jobvt, char range,
@@ -73,12 +77,12 @@ lapack_int API_SUFFIX(LAPACKE_cgesvdx)( int matrix_layout, char jobu, char jobvt
         LAPACKE_malloc( sizeof(lapack_complex_float) * lwork );
     if( work == NULL ) {
         info = LAPACK_WORK_MEMORY_ERROR;
-        goto exit_level_1;
+        goto exit_level_0;
     }
     rwork = (float*)LAPACKE_malloc( sizeof(float) * lrwork );
     if( rwork == NULL ) {
         info = LAPACK_WORK_MEMORY_ERROR;
-        goto exit_level_0;
+        goto exit_level_1;
     }
     iwork = (lapack_int*)LAPACKE_malloc( sizeof(lapack_int) * MAX(1,(12*MIN(m,n))) );
     if( iwork == NULL ) {
@@ -96,9 +100,9 @@ lapack_int API_SUFFIX(LAPACKE_cgesvdx)( int matrix_layout, char jobu, char jobvt
     /* Release memory and exit */
     LAPACKE_free( iwork );
 exit_level_2:
-    LAPACKE_free( work );
-exit_level_1:
     LAPACKE_free( rwork );
+exit_level_1:
+    LAPACKE_free( work );
 exit_level_0:
     if( info == LAPACK_WORK_MEMORY_ERROR ) {
         API_SUFFIX(LAPACKE_xerbla)( "LAPACKE_cgesvdx", info );

src/lapacke/LAPACKE/src/lapacke_chbevx_2stage_work.c

@@ -30,6 +30,10 @@
 * Author: Intel Corporation
 *****************************************************************************/
 
+/*
+ *     Modifications Copyright (c) 2025 Advanced Micro Devices, Inc.  All rights reserved.
+ */
+
 #include "lapacke_utils.h"
 
 lapack_int API_SUFFIX(LAPACKE_chbevx_2stage_work)( int matrix_layout, char jobz, char range,
@@ -105,9 +109,14 @@ lapack_int API_SUFFIX(LAPACKE_chbevx_2stage_work)( int matrix_layout, char jobz,
         }
         /* Query optimal working array(s) size if requested */
         if( lwork == -1 ) {
-             LAPACK_chbevx_2stage( &jobz, &range, &uplo, &n, &kd, ab_t, &ldab_t, q_t,
+            LAPACK_chbevx_2stage( &jobz, &range, &uplo, &n, &kd, ab_t, &ldab_t, q_t,
                        &ldq_t, &vl, &vu, &il, &iu, &abstol, m, w, z_t, &ldz_t,
                        work, &lwork, rwork, iwork, ifail, &info );
+            LAPACKE_free( ab_t );
+            if( LAPACKE_lsame( jobz, 'v' ) ) {
+                LAPACKE_free( q_t );
+                LAPACKE_free( z_t );
+            }
             return (info < 0) ? (info - 1) : info;
         }
         /* Transpose input matrices */