-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol, Domain & port with request.get_url over just reporting the path #415
Comments
I experimented with multiple docker-compose setups and the annoying part of this setup is that this will only appear once you move onto a non-local setup where you have HTTPS. I don't mind working on the PR myself :) Updated: |
Hey, thanks for reporting this and offering to help with it. If I remember correctly it was initially using relative path, then because of the issue that relative path was ignoring the root_path we had to switch to using full URLs: Can you please explain what you mean by unnecessary changes? Like Uvicorn config? |
@Jorricks Any updates with this? |
I don't recall the specifics but I made it work somehow 🤔😅. It might have been some issues with an other app and not with SQLAdmin. Let's close it :) |
Thanks |
Checklist
master
.Describe the bug
When using SQLAdmin behind a proxy, the URLs use 'http://' instead of 'https://'
This can be fixed by setting the Uvicorn proxy settings.
However, using full URLs will lead to many unnecessary issues. Using just paths as mentioned here will work fine in all cases; encode/starlette#538 (comment)
Steps to reproduce the bug
Run SQLAdmin behind a proxy.
Expected behavior
All URLs should just be the subpath.
Actual behavior
All URLs contain the protocol, domain (optinally port as well) and finally the path.
Debugging material
No response
Environment
Python 3.8
SQLAdmin 0.8.0
Additional context
No response
The text was updated successfully, but these errors were encountered: