Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmpDocumentNetworkFirst.makeRequest return is not nullable but method body implies that it might be nullable #47

Open
erwinmombay opened this issue Aug 5, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@erwinmombay
Copy link
Member

inside the body of makeRequest in the AmpDocumentNetworkFirst class there is a check for request where it could be nullable but we return request anyways as the base case and don't state it in the method signature return type.

question really is, does calling makeRequest return something that is nullable from the NetworkFirst implementation in workbox?

@erwinmombay erwinmombay added the bug Something isn't working label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant