✨ [Extension AMP-AD] Implement feature to create a data vars slot id by unit when data-slot is entered - #36160
Closed
kelvinbiffi wants to merge 30 commits into
Closed
Conversation
…ame from use id to index
Author
|
Hi @lannka |
Author
|
Hi @lannka , Did you get a look? Is there anything I need to do? |
Member
|
@ampproject/wg-monetization |
powerivq
requested changes
Oct 9, 2021
Author
|
Hi @powerivq I made the changes you pointed, and I tried to create a 'macro' in amp-analytics consuming that attribute, however, I couldn't find a way to make it work correctly Could you give me a clue about how could I create that macro? |
|
Edmilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Batch closing inactive PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature on this PR is to be able to create a data vars slot id by unit when data-slot is entered
I believe this feature is important to know the quantity os ad unit types have in one page on analytics trigger
psc @gurodrigues