Skip to content

✨ [Extension AMP-AD] Implement feature to create a data vars slot id by unit when data-slot is entered - #36160

Closed
kelvinbiffi wants to merge 30 commits into
ampproject:mainfrom
denakop:feature/amp-ad-data-vars-slot-id-by-unit
Closed

✨ [Extension AMP-AD] Implement feature to create a data vars slot id by unit when data-slot is entered#36160
kelvinbiffi wants to merge 30 commits into
ampproject:mainfrom
denakop:feature/amp-ad-data-vars-slot-id-by-unit

Conversation

@kelvinbiffi

@kelvinbiffi kelvinbiffi commented Sep 24, 2021

Copy link
Copy Markdown

The feature on this PR is to be able to create a data vars slot id by unit when data-slot is entered

I believe this feature is important to know the quantity os ad unit types have in one page on analytics trigger

psc @gurodrigues

@amp-owners-bot
amp-owners-bot Bot requested a review from lannka September 24, 2021 03:48
@kelvinbiffi

Copy link
Copy Markdown
Author

Hi @lannka
I implemented a simple feature to be able to identify the index of the amp-ad by slot units, could you have a look? =)

@kelvinbiffi

Copy link
Copy Markdown
Author

Hi @lannka ,

Did you get a look?

Is there anything I need to do?

@calebcordry

@alanorozco
alanorozco requested review from calebcordry and removed request for lannka October 7, 2021 00:20
@alanorozco

Copy link
Copy Markdown
Member

@ampproject/wg-monetization

Comment thread extensions/amp-ad/0.1/amp-ad.js Outdated
Comment thread extensions/amp-ad/0.1/amp-ad.js Outdated
@kelvinbiffi
kelvinbiffi requested a review from powerivq October 15, 2021 13:51
@kelvinbiffi

Copy link
Copy Markdown
Author

Hi @powerivq

I made the changes you pointed, and I tried to create a 'macro' in amp-analytics consuming that attribute, however, I couldn't find a way to make it work correctly

Could you give me a clue about how could I create that macro?

@CLAassistant

CLAassistant commented Sep 11, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ Edmilson
❌ kelvinbiffi
❌ EdmilsonSilva


Edmilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@powerivq powerivq closed this Sep 6, 2024
@powerivq

powerivq commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Batch closing inactive PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants