Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go/vet composite errors for signer_test.go #507

Open
banaag opened this issue Mar 9, 2021 · 1 comment
Open

Fix go/vet composite errors for signer_test.go #507

banaag opened this issue Mar 9, 2021 · 1 comment

Comments

@banaag
Copy link
Collaborator

banaag commented Mar 9, 2021

Error: packager/signer/signer_test.go:167:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:168:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:220:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:221:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:268:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:269:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:286:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:287:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:301:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:302:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:311:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:312:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:321:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:330:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:343:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:357:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:372:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:386:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:402:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:419:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:436:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:479:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:495:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:516:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:540:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:563:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:586:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:603:11: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:614:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:632:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:652:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:665:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:677:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:692:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:704:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:721:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:738:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:756:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:775:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:793:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:810:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:827:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:848:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:905:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:940:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:1041:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:1064:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:1077:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields
Error: packager/signer/signer_test.go:1148:10: github.com/ampproject/amppackager/packager/util.URLPattern composite literal uses unkeyed fields

github.com/ampproject/amppackager/transformer

Error: transformer/transformer_test.go:314:49: call of t.Fatalf copies lock value: github.com/ampproject/amppackager/transformer/request.Request contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex

@twifkak
Copy link
Member

twifkak commented Apr 6, 2021

Update: The transformer_test error was fixed in one of the "Sync from Google" PRs. The signer_test errors remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants