Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg-infra Status Update 2020-02-03 #25

Open
rsimha opened this issue Feb 3, 2020 · 6 comments
Open

wg-infra Status Update 2020-02-03 #25

rsimha opened this issue Feb 3, 2020 · 6 comments

Comments

@rsimha
Copy link
Collaborator

rsimha commented Feb 3, 2020

What we did

  • Updated amp.dev release schedule page
  • Release tagging is live (PR Use: In Stable / Beta / Experimental)
  • Updated cherry-pick template with new release channel names
  • Added a way to build only the core runtime via gulp build | dist | watch --core_runtime_only
  • Clarified process for adding amphtml dependencies using yarn
  • Triaged backlog of infrastructure issues
  • Renaming AMP_CANARY cookie to __Host-AMP_OPT_IN

What's next

  • Default minified build (gulp dist) will now add AMP_CONFIG to runtime files
  • Performance tests as part of CI / release workflow
  • Make LTS and nightly channel widely available
  • Take steps to reduce CI flakiness (sauce labs, percy)
@rcebulko
Copy link

rcebulko commented Feb 3, 2020

Also release automation for most of the AMP GitHub apps

@alanorozco
Copy link
Member

Is --core_runtime_only different than doing --extensions=amp-img?

@ampproject ampproject deleted a comment from rcebulko Feb 3, 2020
@rsimha
Copy link
Collaborator Author

rsimha commented Feb 3, 2020

Is --core_runtime_only different than doing --extensions=amp-img?

Yes, it only builds amp.js.

Screen Shot 2020-02-03 at 10 54 44 AM

@dreamofabear
Copy link

Any high-level plans for performance tests that can be shared yet? E.g. which metrics and how to manage data noise.

@rcebulko Curious what release automation for our GH apps is. A bit of an overloaded term. 😄

@rsimha
Copy link
Collaborator Author

rsimha commented Feb 3, 2020

Any high-level plans for performance tests that can be shared yet? E.g. which metrics and how to manage data noise.

@estherkim is meeting with folks from @ampproject/wg-performance this week. We should have more on this in the next update.

@rcebulko
Copy link

rcebulko commented Feb 3, 2020

@choumx See ampproject/amp-github-apps#664

TL;DR - Previously only the author of each app (owners, bundle-size, test-status, pr-deploy, etc) could deploy an update in most cases, because it relied on manually deploying to GCloud with a .env with secrets and configs that couldn't be checked in and were rarely shared efficiently. Now any of us can push a tag and deploy an app using encrypted secrets and google cloud build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants