M2 system sent email order confirmation when oder status is payment review / declined #1259

Activity

1. sgabhart22 commented on Jan 2, 2025

   

   sgabhart22

   on Jan 2, 2025

   Contributor

   More actions

   Hello @miracteam ,

   Thanks for the report, this is a known issue with a fix targeted for inclusion in the next release. Until then, I can provide a patch here to address the issue. Please let us know if you continue to have problems!

   asd-1236.patch.txt

   Thanks,
   Spencer
3. sgabhart22 commented on Jan 17, 2025

   

   sgabhart22

   on Jan 17, 2025

   Contributor

   More actions

   Hello @tungho-copilot ,

   Looks like I somehow missed a certain combination of payment action/authorization config values in my testing here... you are absolutely correct, I was able to reproduce this initially with asynchronous email sending disabled and the payment action set to 'authorize and capture'. I was certain I tested this scenario but maybe caching got the best of me; at any rate, I'm attaching another patch here that simplifies things a bit with only one plugin, but should still cover all combinations of Amazon + Magento config in terms of order processing and email settings. Please let us know if you continue to have issues, and my apologies again for missing this the first time!

   asd-1236-updated.patch.txt

   Thanks,
   Spencer
6. sgabhart22 commented on Feb 17, 2025

   

   sgabhart22

   on Feb 17, 2025

   Contributor

   More actions

   Hi again @tungho-copilot ,

   Very sorry for the continued issues, we hit a couple snags getting the latest release out. I'm attaching the final version of this fix that will be included. My apologies again for the back and forth, and thanks for your patience.

   asd-1236-final.patch.txt
7. sgabhart22 commented on Aug 21, 2025

   

   sgabhart22

   on Aug 21, 2025

   Contributor

   More actions

   Hell @miracteam , just letting you know these fixes are now live, so we'll closing this issue soon.

   Thanks,
   Spencer
8. nige-one commented on May 5, 2026

   

   nige-one

   on May 5, 2026

   More actions

   We have the same issue from a different angle. Somestimes customers do not complete payment on Amazon. We have stale orders afterwards. If we cancel the orders from backend the customer receives another order confirmation mail.

   when admin manually cancels a stuck Amazon Pay order (payment_review / pending_payment), Magento's Order::registerCancellation() (Model/Order.php:1361-1391) transiently calls setState(STATE_PROCESSING) if any item has qtyToRefund — which trips the state == STATE_PROCESSING branch in Plugin/SendEmail::afterSetState (Plugin/SendEmail.php:64) and fires orderSender->send().
   The order ends up canceled, but the new-order confirmation email has already gone out. On our shop 21 canceled Amazon Pay orders ended up with email_sent=1 this way.
9. nige-one commented on May 5, 2026

   

   nige-one

   on May 5, 2026

   More actions

   That's what Claude spit out and I'm using successfully:

   diff --git a/Plugin/SendEmail.php b/Plugin/SendEmail.php                                                                                                                                                                            
   --- a/Plugin/SendEmail.php                                                                                                                                                                                                          
   +++ b/Plugin/SendEmail.php
   @@ -61,9 +61,17 @@ class SendEmail                                                                                                                                                                                                  
                if ($this->scopeConfig->getValue('sales_email/order/enabled')) {                                                                                                                                                       
                    $subject->setCanSendNewEmailFlag(false);                                                                                                                                                                           
                                                                                                                                                                                                                                       
                    if ($subject->getState() == Order::STATE_PROCESSING &&                                                                                                                                                             
                        !empty($subject->getStatusHistories()) &&                  
                        !$subject->getEmailSent()                                                                                                                                                                                      
                        ) {                                                        
   +                    foreach ($subject->getAllItems() as $item) {                                                                                                                                                                   
   +                        if ($item->getQtyCanceled() > 0) {
   +                            // Inside Order::registerCancellation(): items are                                                                                                                                                     
   +                            // cancelled before setState() runs, and a transient                                                                                                                                                   
   +                            // STATE_PROCESSING can be set when items have qty                                                                                                                                                     
   +                            // to refund. Suppress the confirmation email.                                                                                                                                                         
   +                            return $result;                                                                                                                                                                                        
   +                        }                                                                                                                                                                                                          
   +                    }                                                                                                                                                                                                              
                        $subject->setCanSendNewEmailFlag(true);
                        $this->orderSender->send($subject);                                                                                                                                                                            
                    } 
   
10. nige-one commented on Jun 7, 2026

    

    nige-one

    on Jun 7, 2026

    More actions

    I just added a PR with hardened fix - our merchant always finds ways...