Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to create global configuration for sidekiq_mailer #16

Open
coderhs opened this issue Aug 14, 2014 · 3 comments
Open

How to create global configuration for sidekiq_mailer #16

coderhs opened this issue Aug 14, 2014 · 3 comments

Comments

@coderhs
Copy link
Contributor

coderhs commented Aug 14, 2014

Is it possible to create a global config and set all the mails to be send to queue named 'default'.

@coderhs coderhs changed the title Create global configuration for sidekiq_mailer How to create global configuration for sidekiq_mailer Aug 14, 2014
@coderhs
Copy link
Contributor Author

coderhs commented Aug 14, 2014

@andersondias Is it possible to add an initializer and configure the gem to add to a particular queue?

@andersondias
Copy link
Owner

Nope, it's not possible right now. A Pull Request with this would be awesome :D

@coderhs
Copy link
Contributor Author

coderhs commented Aug 19, 2014

@andersondias : I have worked on it a bit. It is working the code can be found here https://github.com/coderhs/sidekiq_mailer/tree/configure. I have written the test for the configuration as a separate file so moved the common class to the test helper. Individually running the test file they pass, but when i run them together. The configuration that I have set for one test seems to persist when other test runs thus causing issues. I haven't been able to solve it. Will look into that issue soon and send a pull request.

PS: Feel free to correct or point out any mistakes, in the way i have written the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants