fix(clayui): harden widget state handling

Author: andreakarasho

src/Clay.Test/ClayUIBasicWidgetTests.cs

@@ -46,6 +46,17 @@ public void Button_Clicked_ReturnsTrue()
         Assert.True(clicked);
     }
 
+    [Fact]
+    public void Button_Clicked_UpdatesQueryState()
+    {
+        _fixture.Click(
+            () => ClayUI.Button("QueryBtn"),
+            mousePos: new Vector2(40, 10));
+
+        Assert.True(ClayUI.WasHovered("QueryBtn"));
+        Assert.True(ClayUI.WasClicked("QueryBtn"));
+    }
+
     [Fact]
     public void Button_ClickOutside_ReturnsFalse()
     {
@@ -277,6 +288,12 @@ public void ProgressBar_CustomRange()
         _fixture.RunFrame(() => ClayUI.ProgressBar(50f, min: 0f, max: 100f));
     }
 
+    [Fact]
+    public void ProgressBar_ZeroRange_DoesNotCrash()
+    {
+        _fixture.RunFrame(() => ClayUI.ProgressBar(10f, min: 10f, max: 10f));
+    }
+
     // ============ Image ============
 
     [Fact]

src/Clay.Test/ClayUIColorPickerTests.cs

@@ -0,0 +1,44 @@
+using System.Collections;
+using System.Reflection;
+using Clay;
+
+namespace Clay.Test;
+
+public class ClayUIColorPickerTests : IDisposable
+{
+    private readonly ClayUIFixture _fixture;
+
+    public ClayUIColorPickerTests()
+    {
+        _fixture = new ClayUIFixture();
+    }
+
+    public void Dispose() => _fixture.Dispose();
+
+    [Fact]
+    public void ColorPicker_StateKey_RemainsStable_WhenWidgetOrderChanges()
+    {
+        _fixture.RunFrame(() =>
+        {
+            ClayUI.Button("BeforePicker");
+            _ = ClayUI.ColorPicker("Picker", Color.Red);
+        });
+
+        _fixture.RunFrame(() =>
+        {
+            _ = ClayUI.ColorPicker("Picker", Color.Red);
+        });
+
+        Assert.Equal(1, GetColorPickerStateCount());
+    }
+
+    private static int GetColorPickerStateCount()
+    {
+        var handle = ClayUI.GetContext();
+        var uiContextProp = typeof(ClayUIContextHandle).GetProperty("UIContext", BindingFlags.Instance | BindingFlags.NonPublic)!;
+        var uiContext = uiContextProp.GetValue(handle)!;
+        var statesField = uiContext.GetType().GetField("ColorPickerStates", BindingFlags.Instance | BindingFlags.NonPublic)!;
+        var states = (IDictionary)statesField.GetValue(uiContext)!;
+        return states.Count;
+    }
+}

src/Clay.Test/ClayUIFixture.cs

@@ -22,9 +22,10 @@ public ReadOnlySpan<RenderCommand> RunFrame(
         Vector2 mousePos = default,
         bool mouseDown = false,
         Vector2 scrollDelta = default,
-        float deltaTime = 1f / 60f)
+        float deltaTime = 1f / 60f,
+        bool rightMouseDown = false)
     {
-        ClayUI.BeginFrame(new Dimensions(800, 600), mouseDown, mousePos, scrollDelta, deltaTime);
+        ClayUI.BeginFrame(new Dimensions(800, 600), mouseDown, mousePos, scrollDelta, deltaTime, rightMouseDown);
 
         // Root container so widgets have a parent with known size
         using (ClayApi.Element(new ElementDeclaration
@@ -52,13 +53,14 @@ public ReadOnlySpan<RenderCommand> RunTwoFrames(
         Action buildUi,
         Vector2 mousePos = default,
         bool mouseDown = false,
-        Vector2 scrollDelta = default)
+        Vector2 scrollDelta = default,
+        bool rightMouseDown = false)
     {
         // Frame 1: establish bounding boxes (no interaction)
         RunFrame(buildUi, mousePos, mouseDown: false);
 
         // Frame 2: with actual mouse state for interaction
-        return RunFrame(buildUi, mousePos, mouseDown, scrollDelta);
+        return RunFrame(buildUi, mousePos, mouseDown, scrollDelta, rightMouseDown: rightMouseDown);
     }
 
     /// <summary>
@@ -78,6 +80,16 @@ public ReadOnlySpan<RenderCommand> Click(Action buildUi, Vector2 mousePos)
         return RunFrame(buildUi, mousePos, mouseDown: false);
     }
 
+    /// <summary>
+    /// Simulates a secondary-button click: establish bounds, press right button, release.
+    /// </summary>
+    public ReadOnlySpan<RenderCommand> RightClick(Action buildUi, Vector2 mousePos)
+    {
+        RunFrame(buildUi, mousePos, mouseDown: false, rightMouseDown: false);
+        RunFrame(buildUi, mousePos, mouseDown: false, rightMouseDown: true);
+        return RunFrame(buildUi, mousePos, mouseDown: false, rightMouseDown: false);
+    }
+
     public void Dispose()
     {
         ClayUI.ClearState();

src/Clay.Test/ClayUIPopupTests.cs

@@ -234,6 +234,56 @@ public void BeginContextMenu_WhenNotTriggered_ReturnsFalse()
         Assert.False(opened);
     }
 
+    [Fact]
+    public void BeginContextMenu_LeftClick_DoesNotOpen()
+    {
+        var triggerId = ClayApi.Id("trigger_left");
+        bool opened = true;
+
+        _fixture.Click(() =>
+        {
+            using (ClayApi.Element(new ElementDeclaration
+            {
+                Id = triggerId,
+                Layout = new LayoutConfig { Sizing = Sizing.FixedSize(100, 100) },
+                BackgroundColor = Color.Gray
+            })) { }
+
+            opened = ClayUI.BeginContextMenu("ctx_left", triggerId);
+            if (opened)
+                ClayUI.MenuItem("Should stay closed");
+            ClayUI.EndContextMenu();
+        }, mousePos: new Vector2(20, 20));
+
+        Assert.False(opened);
+        Assert.False(ClayUI.IsPopupOpen("ctx_left"));
+    }
+
+    [Fact]
+    public void BeginContextMenu_RightClick_OpensAndClosesCleanly()
+    {
+        var triggerId = ClayApi.Id("trigger_right");
+        bool opened = false;
+
+        _fixture.RightClick(() =>
+        {
+            using (ClayApi.Element(new ElementDeclaration
+            {
+                Id = triggerId,
+                Layout = new LayoutConfig { Sizing = Sizing.FixedSize(100, 100) },
+                BackgroundColor = Color.Gray
+            })) { }
+
+            opened = ClayUI.BeginContextMenu("ctx_right", triggerId);
+            if (opened)
+                ClayUI.MenuItem("Action");
+            ClayUI.EndContextMenu();
+        }, mousePos: new Vector2(20, 20));
+
+        Assert.True(opened);
+        Assert.True(ClayUI.IsPopupOpen("ctx_right"));
+    }
+
     // ============ OpenPopupBelow ============
 
     [Fact]

src/Clay.Test/ClayUISliderTests.cs

@@ -50,6 +50,13 @@ public void Slider_CustomRange_Renders()
         _fixture.RunFrame(() => ClayUI.Slider("S3", ref val, min: 0f, max: 100f));
     }
 
+    [Fact]
+    public void Slider_ZeroRange_DoesNotCrash()
+    {
+        float val = 10f;
+        _fixture.RunFrame(() => ClayUI.Slider("SZero", ref val, min: 10f, max: 10f));
+    }
+
     [Fact]
     public void Slider_EmptyLabel_Renders()
     {

src/Clay.Test/ClayUITooltipTests.cs

@@ -179,6 +179,40 @@ public void BeginTooltip_ReturnsTrue_AfterDelay()
         Assert.True(opened, "BeginTooltip should return true after hover delay");
     }
 
+    [Fact]
+    public void Tooltip_TextInputTarget_Renders_AfterDelay()
+    {
+        string text = "hello";
+
+        _fixture.RunFrame(() =>
+        {
+            ClayUI.TextInput("InputTip", ref text);
+            ClayUI.Tooltip("Input tip");
+        }, mousePos: new Vector2(20, 10));
+
+        ReadOnlySpan<RenderCommand> commands = default;
+        for (int i = 0; i < 5; i++)
+        {
+            commands = _fixture.RunFrame(() =>
+            {
+                ClayUI.TextInput("InputTip", ref text);
+                ClayUI.Tooltip("Input tip");
+            }, mousePos: new Vector2(20, 10), deltaTime: 0.2f);
+        }
+
+        bool hasTooltipText = false;
+        foreach (var cmd in commands)
+        {
+            if (cmd.CommandType == RenderCommandType.Text && cmd.Text.Text == "Input tip")
+            {
+                hasTooltipText = true;
+                break;
+            }
+        }
+
+        Assert.True(hasTooltipText, "Tooltip should render for stable-ID widgets like TextInput");
+    }
+
     [Fact]
     public void Tooltip_OnlyOnePerFrame()
     {