fix compiler warning (openhab#17085)

mlobstein · web-flow · commit 3a5bee0412f4 · 2024-07-17T08:38:13.000+02:00
Signed-off-by: Michael Lobstein &lt;michael.lobstein@gmail.com&gt;
diff --git a/bundles/org.openhab.binding.monopriceaudio/src/main/java/org/openhab/binding/monopriceaudio/internal/communication/AmplifierModel.java b/bundles/org.openhab.binding.monopriceaudio/src/main/java/org/openhab/binding/monopriceaudio/internal/communication/AmplifierModel.java
@@ -270,20 +270,16 @@ private static MonopriceAudioZoneDTO getMonopriceZoneData(String newZoneData) {
 
     public String getZoneIdFromZoneName(String zoneName) {
         for (String zoneId : zoneIdMap.keySet()) {
-            if (zoneIdMap.get(zoneId).equals(zoneName)) {
+            if (zoneName.equals(zoneIdMap.get(zoneId))) {
                 return zoneId;
             }
         }
         return "";
     }
 
     public String getZoneName(String zoneId) {
-        String zoneName = zoneIdMap.get(zoneId);
-        if (zoneName != null) {
-            return zoneName;
-        } else {
-            return "";
-        }
+        final String zoneName = zoneIdMap.get(zoneId);
+        return zoneName != null ? zoneName : "";
     }
 
     public String getCmdPrefix() {

Original file line number	Diff line number	Diff line change
`@@ -270,20 +270,16 @@ private static MonopriceAudioZoneDTO getMonopriceZoneData(String newZoneData) {`
`270`	`270`
`271`	`271`	`public String getZoneIdFromZoneName(String zoneName) {`
`272`	`272`	`for (String zoneId : zoneIdMap.keySet()) {`
`273`		`- if (zoneIdMap.get(zoneId).equals(zoneName)) {`
	`273`	`+ if (zoneName.equals(zoneIdMap.get(zoneId))) {`
`274`	`274`	`return zoneId;`
`275`	`275`	`}`
`276`	`276`	`}`
`277`	`277`	`return "";`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`public String getZoneName(String zoneId) {`
`281`		`- String zoneName = zoneIdMap.get(zoneId);`
`282`		`- if (zoneName != null) {`
`283`		`- return zoneName;`
`284`		`- } else {`
`285`		`- return "";`
`286`		`- }`
	`281`	`+ final String zoneName = zoneIdMap.get(zoneId);`
	`282`	`+ return zoneName != null ? zoneName : "";`
`287`	`283`	`}`
`288`	`284`
`289`	`285`	`public String getCmdPrefix() {`