Skip to content

Commit 3e7162d

Browse files
authored
[opensprinkler] Fix excessive WARN in logs due to wifi dropouts, and current displays as 0 (openhab#16080)
* Fix 300mA current draw will display as 0 due to rounding. * Remove WARN logs when retries have not yet expired. Signed-off-by: Matthew Skinner <[email protected]>
1 parent 9872ca7 commit 3e7162d

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

bundles/org.openhab.binding.opensprinkler/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV100.java

+2-10
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,7 @@
1212
*/
1313
package org.openhab.binding.opensprinkler.internal.api;
1414

15-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.CMD_DISABLE_MANUAL_MODE;
16-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.CMD_ENABLE_MANUAL_MODE;
17-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.CMD_OPTIONS_INFO;
18-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.CMD_PASSWORD;
19-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.CMD_STATION_INFO;
20-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.CMD_STATUS_INFO;
21-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.DEFAULT_STATION_COUNT;
22-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.HTTPS_REQUEST_URL_PREFIX;
23-
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.HTTP_REQUEST_URL_PREFIX;
15+
import static org.openhab.binding.opensprinkler.internal.OpenSprinklerBindingConstants.*;
2416

2517
import java.math.BigDecimal;
2618
import java.nio.charset.StandardCharsets;
@@ -397,7 +389,7 @@ public String sendHttpGet(String url, @Nullable String urlParameters)
397389
.timeout(config.timeout, TimeUnit.SECONDS).method(HttpMethod.GET).send();
398390
connectionSuccess = true;
399391
} catch (InterruptedException | TimeoutException | ExecutionException e) {
400-
logger.warn("Request to OpenSprinkler device failed (retries left: {}): {}", retriesLeft,
392+
logger.debug("Request to OpenSprinkler device failed (retries left: {}): {}", retriesLeft,
401393
e.getMessage());
402394
}
403395
}

bundles/org.openhab.binding.opensprinkler/src/main/resources/OH-INF/thing/thing-types.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
<label>Current Draw</label>
164164
<description>The current draw in mA</description>
165165
<category>Energy</category>
166-
<state readOnly="true"/>
166+
<state readOnly="true" pattern="%.1f %unit%"/>
167167
</channel-type>
168168

169169
<channel-type id="stationState">

0 commit comments

Comments
 (0)