Skip to content

Commit 7639b1c

Browse files
authored
Fix SAT errors (openhab#18047)
Signed-off-by: Leo Siepel <[email protected]>
1 parent 8a442d9 commit 7639b1c

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

bundles/org.openhab.binding.digiplex/src/main/java/org/openhab/binding/digiplex/internal/DigiplexAreaConfiguration.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,15 @@
1212
*/
1313
package org.openhab.binding.digiplex.internal;
1414

15+
import org.eclipse.jdt.annotation.NonNullByDefault;
16+
1517
/**
1618
* The {@link DigiplexAreaConfiguration} class contains fields mapping area configuration parameters.
1719
*
1820
* @author Robert Michalak - Initial contribution
1921
*/
22+
@NonNullByDefault
2023
public class DigiplexAreaConfiguration {
2124

22-
public int refreshPeriod;
25+
public int refreshPeriod = 60;
2326
}

bundles/org.openhab.binding.digiplex/src/main/java/org/openhab/binding/digiplex/internal/DigiplexBridgeConfiguration.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,16 @@
1212
*/
1313
package org.openhab.binding.digiplex.internal;
1414

15+
import org.eclipse.jdt.annotation.NonNullByDefault;
16+
1517
/**
1618
* The {@link DigiplexBridgeConfiguration} class contains fields mapping bridge configuration parameters.
1719
*
1820
* @author Robert Michalak - Initial contribution
1921
*/
22+
@NonNullByDefault
2023
public class DigiplexBridgeConfiguration {
2124

22-
public String port;
23-
public int baudrate;
25+
public String port = "";
26+
public int baudrate = 2400;
2427
}

bundles/org.openhab.binding.digiplex/src/main/java/org/openhab/binding/digiplex/internal/handler/DigiplexBridgeHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public DigiplexBridgeHandler(Bridge bridge, SerialPortManager serialPortManager)
102102
@Override
103103
public void initialize() {
104104
config = getConfigAs(DigiplexBridgeConfiguration.class);
105-
if (config.port == null) {
105+
if (config.port.isBlank()) {
106106
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.OFFLINE.CONFIGURATION_ERROR, "Port must be set!");
107107
return;
108108
}

0 commit comments

Comments
 (0)