Skip to content

Commit b710c6b

Browse files
authored
Fix mapdb after core change (openhab#18285)
Signed-off-by: Mark Herwege <[email protected]>
1 parent 655116f commit b710c6b

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

bundles/org.openhab.persistence.mapdb/src/main/java/org/openhab/persistence/mapdb/internal/MapDbPersistenceService.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -211,13 +211,17 @@ public Iterable<HistoricItem> query(FilterCriteria filter) {
211211
}
212212

213213
@Override
214-
public @Nullable PersistedItem persistedItem(String itemName) {
215-
String json = map.get(itemName);
214+
public @Nullable PersistedItem persistedItem(String itemName, @Nullable String alias) {
215+
String json = map.get(alias != null ? alias : itemName);
216216
if (json == null) {
217217
return null;
218218
}
219219
Optional<MapDbItem> item = deserialize(json);
220-
return item.orElse(null);
220+
MapDbItem dbItem = item.orElse(null);
221+
if (dbItem != null) {
222+
dbItem.setName(itemName);
223+
}
224+
return dbItem;
221225
}
222226

223227
private String serialize(MapDbItem item) {

itests/org.openhab.persistence.mapdb.tests/src/main/java/org/openhab/persistence/mapdb/MapDbPersistenceServiceOSGiTest.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ public void queryShouldFindStoredItemsByAlias() {
135135
assertThat(persistenceService.query(filterByName), is(emptyIterable()));
136136
waitForAssert(() -> assertThat(persistenceService.query(filterByAlias),
137137
contains(allOf(hasProperty("name", equalTo(alias)), hasProperty("state", equalTo(state))))));
138+
waitForAssert(() -> assertThat(persistenceService.query(filterByName, alias),
139+
contains(allOf(hasProperty("name", equalTo(name)), hasProperty("state", equalTo(state))))));
138140
}
139141

140142
@Test
@@ -148,11 +150,11 @@ public void persistedItemShouldFindItem() {
148150
GenericItem item = new DimmerItem(name);
149151
item.setState(state, lastState, lastStateUpdate, lastStateChange);
150152

151-
assertNull(persistenceService.persistedItem(name));
153+
assertNull(persistenceService.persistedItem(name, null));
152154

153155
persistenceService.store(item);
154156

155-
waitForAssert(() -> assertThat(persistenceService.persistedItem(name),
157+
waitForAssert(() -> assertThat(persistenceService.persistedItem(name, null),
156158
allOf(hasProperty("name", equalTo(name)), hasProperty("state", equalTo(state)),
157159
hasProperty("lastState", equalTo(lastState)),
158160
hasProperty("timestamp", any(ZonedDateTime.class)),

0 commit comments

Comments
 (0)