move the Prim helper module into into primitive test suite

[cartazio]

then test suite can be part of the normal cabal file and all the test suite deps dont have to be rebuilt every time via the cabal project file...

(which i personally find maddening for local hackery)

[cartazio]

i'll see about doing some PRs for this, though i may just vendor the whole package just to keep things sane on my side ..

[cartazio]

i guess another option would be to make the primitive deps conditional so primitive can have a copy of that module to avoid build cycles, but where other packages dont set the -f-primitive flag or whatever so they get it? (maybe that would be a nicer change for you / would you be open to that?)

[andrewthad]

I'd be fine with having a -f-primitive flag to disable the primitive dependency. We would need to copy primLaws into the test suite for primitive. In this setup, the test suite still couldn't be part of the normal the normal primitive.cabal file since it would require building quickcheck-classes with a bunch of flags set. But I think that's a small price to pay for the benefit of getting more tests for things like Eq, Show, Read, Foldable, Traversable, etc. as they are contributed to quickcheck-classes.

[cartazio]

gotcha, ideally I'd really like to shift things around so that we can use normal testing stanzas at least, but just killing the rebuild pain would be nice. (it drives me crazy, plus the cabal project vendored deps actually leak into my local project file search results :) )

[cartazio]

@andrewthad i have a strawman of this jankily done with primitive 0.7 / master, let me know how we can progress on this side :)

[andrewthad]

At some point in the next month, I'm going to split a quickcheck-classes-base out of quickcheck-classes. There shouldn't be any problem with primitive's test suite depending on quickcheck-classes-base. We'll still need to copy primLaws into primitive's test suite. This will eliminate something like 90% of the code duplication.

[cartazio]

i did copy them, if you look at current primitive master, its in the test suite some things were failing ot type check so i just killed them for now till i cleaned up the "prim laws" / work thorugh what they are

…

On Fri, May 24, 2019 at 1:46 PM Andrew Martin ***@***.***> wrote: At some point in the next month, I'm going to split a quickcheck-classes-base out of quickcheck-classes. There shouldn't be any problem with primitive's test suite depending on quickcheck-classes-base. We'll still need to copy primLaws into primitive's test suite. This will eliminate something like 90% of the code duplication. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#100?email_source=notifications&email_token=AAABBQRPW7KLACKAXNNPO7DPXBH4FA5CNFSM4HJWHXDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGQ5BQ#issuecomment-495783558>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABBQRZ5UHETT2Y7SH6HDDPXBH4FANCNFSM4HJWHXDA> .

[chessai]

@cartazio this is pretty much done, and our crappy CI passes for all GHCs >= 7.4, so we just need to make a release of both packages.

[andrewthad]

quickcheck-classes-base is now on hackage. This doesn't transitively depend on primitive, so it should be able to be used in primitive's test suite.

[cartazio]

YAY, thank you very very much :)