Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Removing the un-used viewModelProviderFactoryOf from the jetcaster project. #1528

Open
iamjosephmj opened this issue Jan 25, 2025 · 3 comments
Assignees

Comments

@iamjosephmj
Copy link

iamjosephmj commented Jan 25, 2025

I'm not sure if clean-up PRs are accepted, as I only see templates for bug and feature requests. If this function is kept for a reason, I will close this issue.

Sample App

Jetcaster

What Happened?

Currently, the Jetcaster app uses Hilt for DI, which handles view model creation with the Hilt annotations. This makes the com.example.jetcaster.util.viewModelProviderFactoryOf() unused, as view model creation is already managed by simply using hiltViewModel().

Proposed solution

The proposal is to remove com.example.jetcaster.util.ViewModel.kt, as it is no longer needed for view model creation.

@KrishnaTech6
Copy link

Hi there , kindly assign this to me , Thanks

@iamjosephmj
Copy link
Author

iamjosephmj commented Feb 19, 2025

@KrishnaTech6 thankyou, i already have a PR in line after I created the issue. I am waiting for the confirmation. Cheers.

@KrishnaTech6
Copy link

@imjoz Okay, Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants