Clustered via grouping markers disappear after destroy/create

[nmccready]

From @ivan-antonyuck on May 22, 2015 13:20

I found one more issue with clustering.
If i create a map with clustering via 'group' attribute on marker, and then destroy it with ng-if and then recreate again markers will not appear.

plunker is here:
http://plnkr.co/edit/VmBaz8Qm4GgjCbJR6vAB?p=preview

To replicate uncheck the checkbox and then check it again.
I'm not exactly sure that it is not a leaflet.markercluster.js issue, though.

Upd.:
Replicated in Chrome 41 and firefox 38 and 40 on OS X

Copied from original issue: tombatossals/angular-leaflet-directive#769

[nmccready]

From @FabianMeul on May 26, 2015 9:58

I'm also having this issue. Any updates on this?

[nmccready]

From @rasmi on June 15, 2015 18:14

Still having this issue in the latest 0.8.4 release.

[nmccready]

Sounds like destroy is not killing all the markers in leafletData when it should. Sounds like a simple fix.

[nmccready]

From @esetnik on June 24, 2015 14:53

@nmccready I just got hit with the same issue. I'm not too familiar with angular-leaflet-directive but can you point me towards the suspect area and i'll work towards a PR?

I found that manually calling the leafletMarkersHelpers.resetMarkerGroups() fixes the bug but I believe this is not the proper solution.

            getLayers().then(function (layers) {
              var _clean = function (models, oldModels) {
                leafletMarkersHelpers.resetMarkerGroups();
                _destroy(models, oldModels, leafletMarkers, map, layers);
              };

[nmccready]

Might be related to this #815 , please test against master.

[nmccready]

From @esetnik on June 24, 2015 17:6

Unfortunately it is still not working against tombatossals/angular-leaflet-directive@40abcb1

[nmccready]

From @esetnik on July 1, 2015 17:4

any updates on this? How can I help?

[nmccready]

From @jessertaylor on July 3, 2015 10:11

Actually this is the bug that I also ran into, I can confirm this is present in the master.

I'll see if I can debug and fix this.

[nmccready]

From @joeljeske on August 28, 2015 14:24

Also having this issue. Any ideas or fixes?

I actually ran into it inside of a UI Router State: the map and marker clusters would load fine the first time but on sequentially views of the state, the markers were not visible.

[nmccready]

Try using it without watches.

https://github.com/tombatossals/angular-leaflet-directive/blob/d386b7f8f7bd201e1e3d467d5e61c67045a56570/examples/0605-mixed-overlays-markers-nested-no-watch-example.html#L162

https://github.com/tombatossals/angular-leaflet-directive/blob/d386b7f8f7bd201e1e3d467d5e61c67045a56570/examples/0605-mixed-overlays-markers-nested-no-watch-example.html#L31

If you have multiple updates force them all to wait via $q.all and then call create as linked above. I know this is ideal but it is a possible work around.

[nmccready]

From @joeljeske on August 28, 2015 14:45

Thanks for the quick reply. Unfortunately that does not appear to be working. Here is my setup:

angular.module('map').controller('MapCtrl', function($scope, $markers){
    // Defined in another block as an array of objects with 'lat', 'lng', and a 'group' property
    $scope.markers = $markers,
    $scope.markersWatchOptions = {
        doWatch: false,
        isDeep: false,
        individual: {
            doWatch: false,
            isDeep: false
        }
    };
    $scope.layers = {
        baselayers: {
            osm: {
                name: 'OpenStreetMap',
                url: 'http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png',
                type: 'xyz'
            }
        },
        overlays: {
            clusters: {
                name: "Orders",
                type: "markercluster",
                visible: true
            }
        }
    }
});

<leaflet 
    width="100%"
    height="500px"
    markers="markers"
    markers-watch-options="markersWatchOptions"
    layers="layers">
</leaflet>

[nmccready]

From @joeljeske on August 28, 2015 15:51

Here is a sample plunker demonstrating the issue. Toggle between the states and notice the clusters only appear on first viewing.

http://plnkr.co/edit/NYO66s9kJTowzJhBJLoh?p=preview

[nmccready]

Thanks for the example; I'll try and find some time to look at it.

[nmccready]

From @remast on September 13, 2015 18:57

+1 from me I noticed this bug too.