Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ddd6812

Browse files
committedMar 26, 2025·
Revert "refactor: use platformBrowser instead of platformBrowserTesting"
This reverts commit e5e51a2.
1 parent 34c2530 commit ddd6812

File tree

4 files changed

+7
-15
lines changed

4 files changed

+7
-15
lines changed
 

‎packages/angular/build/src/builders/karma/polyfills/init_test_bed.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,10 @@
77
*/
88

99
import { getTestBed } from '@angular/core/testing';
10-
import { platformBrowser } from '@angular/platform-browser';
11-
import { BrowserTestingModule } from '@angular/platform-browser/testing';
10+
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
1211

13-
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
1412
// Initialize the Angular testing environment.
15-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
13+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
1614
errorOnUnknownElements: true,
1715
errorOnUnknownProperties: true,
1816
});

‎packages/angular_devkit/build_angular/src/builders/jest/init-test-bed.mjs

+2-4
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@
1010
// `@angular-devkit/build-angular` rather than the user's workspace. Should look into virtual modules to support those use cases.
1111

1212
import { getTestBed } from '@angular/core/testing';
13-
import { platformBrowser } from '@angular/platform-browser';
14-
import { BrowserTestingModule } from '@angular/platform-browser/testing';
13+
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
1514

16-
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
17-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
15+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
1816
errorOnUnknownElements: true,
1917
errorOnUnknownProperties: true,
2018
});

‎packages/angular_devkit/build_angular/src/builders/karma/browser_builder.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,10 @@ function getBuiltInMainFile(): string {
153153
const content = Buffer.from(
154154
`
155155
import { getTestBed } from '@angular/core/testing';
156-
import { platformBrowser } from '@angular/platform-browser';
157156
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
158157
159-
// TODO(alanagius): replace with \`platformBrowserTesting\` once https://github.com/angular/angular/pull/60480 is released.
160158
// Initialize the Angular testing environment.
161-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
159+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
162160
errorOnUnknownElements: true,
163161
errorOnUnknownProperties: true
164162
});

‎packages/angular_devkit/build_angular/src/builders/web-test-runner/jasmine_runner.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
*/
88

99
import { getTestBed } from '@angular/core/testing';
10-
import { platformBrowser } from '@angular/platform-browser';
11-
import { BrowserTestingModule } from '@angular/platform-browser/testing';
10+
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
1211
import {
1312
getConfig,
1413
sessionFailed,
@@ -65,8 +64,7 @@ export async function runJasmineTests(jasmineEnv) {
6564
jasmine.DEFAULT_TIMEOUT_INTERVAL = config.defaultTimeoutInterval;
6665

6766
// Initialize `TestBed` automatically for users. This assumes we already evaluated `zone.js/testing`.
68-
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
69-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
67+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
7068
errorOnUnknownElements: true,
7169
errorOnUnknownProperties: true,
7270
});

0 commit comments

Comments
 (0)
Please sign in to comment.