fix: fix the passThru feature which wasn’t implemented properly in v0.4.0 (#134)

closes #133

Author: wardbell

CHANGELOG.md

@@ -9,12 +9,23 @@ We do try to tell you about such changes in this `CHANGELOG.md`
 
 and we fix bugs as fast as we can.
 
+<a id="0.4.1"></a>
+## 0.4.1 (2017-09-08)
+**Support PassThru.**
+
+The passthru feature was broken by 0.4.0
+- add passthru to both `Http` and `HttpClient`
+- test passThru feature with jasmine-ajax mock-ajax plugin 
+to intercept Angular's attempt to call browser's XHR
+- update devDependency packages
+- update karma.conf with jasmine-ajax plugin
+
 <a id="0.4.0"></a>
-## 0.4.0 (2017-09-08)
+## 0.4.0 (2017-09-07)
 **Theme: Support `HttpClient` and add tests**.
 See PR #130.
 
-BREAKING CHANGES: Massive refactoring.
+**BREAKING CHANGES**: Massive refactoring.
 Many low-level and customization options have changed.
 Apps that stuck with defaults should be (mostly) OK.
 

README.md

@@ -385,7 +385,7 @@ compiling your application project.
 
 - `npm run build` to confirm the project compiles w/o error (sanity check)
 
-- `npm test`  to build and run tests (see "Testing" below)
+- `npm test`  to build and run tests (see ["Testing"](#testing) below)
 
 - `gulp build`
 - commit and push

backend.service.js

@@ -578,7 +578,6 @@ var BackendService = (function () {
         this.config.host = loc.host; // default to app web server host
         this.config.rootPath = loc.path; // default to path when app is served (e.g.'/')
         Object.assign(this.config, config);
-        this.setPassThruBackend();
     }
     ////  protected /////
     /**
@@ -647,8 +646,11 @@ var BackendService = (function () {
             // request is for a collection created by the InMemoryDbService
             return this.createResponse$(function () { return _this.collectionHandler(reqInfo); });
         }
-        else if (this.passThruBackend) {
+        else if (this.config.passThruUnknownUrl) {
             // Passes request thru to a "real" backend.
+            if (!this.passThruBackend) {
+                this.setPassThruBackend();
+            }
             return this.passThruBackend.handle(req);
         }
         else {
@@ -1156,22 +1158,19 @@ var HttpBackendService = (function (_super) {
         });
     };
     HttpBackendService.prototype.setPassThruBackend = function () {
-        this.passThruBackend = undefined;
-        if (this.config.passThruUnknownUrl) {
-            try {
-                // copied from @angular/http/backends/xhr_backend
-                var browserXhr = this.injector.get(_angular_http.BrowserXhr);
-                var baseResponseOptions = this.injector.get(_angular_http.ResponseOptions);
-                var xsrfStrategy = this.injector.get(_angular_http.XSRFStrategy);
-                var xhrBackend_1 = new _angular_http.XHRBackend(browserXhr, baseResponseOptions, xsrfStrategy);
-                this.passThruBackend = {
-                    handle: function (req) { return xhrBackend_1.createConnection(req).response; }
-                };
-            }
-            catch (e) {
-                e.message = 'Cannot create passThru404 backend; ' + (e.message || '');
-                throw e;
-            }
+        try {
+            // copied from @angular/http/backends/xhr_backend
+            var browserXhr = this.injector.get(_angular_http.BrowserXhr);
+            var baseResponseOptions = this.injector.get(_angular_http.ResponseOptions);
+            var xsrfStrategy = this.injector.get(_angular_http.XSRFStrategy);
+            var xhrBackend_1 = new _angular_http.XHRBackend(browserXhr, baseResponseOptions, xsrfStrategy);
+            this.passThruBackend = {
+                handle: function (req) { return xhrBackend_1.createConnection(req).response; }
+            };
+        }
+        catch (e) {
+            e.message = 'Cannot create passThru404 backend; ' + (e.message || '');
+            throw e;
         }
     };
     return HttpBackendService;
@@ -1262,15 +1261,12 @@ var HttpClientBackendService = (function (_super) {
         return resOptions$.map(function (opts) { return new _angular_common_http.HttpResponse(opts); });
     };
     HttpClientBackendService.prototype.setPassThruBackend = function () {
-        this.passThruBackend = undefined;
-        if (this.config.passThruUnknownUrl) {
-            try {
-                this.passThruBackend = new _angular_common_http.HttpXhrBackend(this.xhrFactory);
-            }
-            catch (ex) {
-                ex.message = 'Cannot create passThru404 backend; ' + (ex.message || '');
-                throw ex;
-            }
+        try {
+            this.passThruBackend = new _angular_common_http.HttpXhrBackend(this.xhrFactory);
+        }
+        catch (ex) {
+            ex.message = 'Cannot create passThru404 backend; ' + (ex.message || '');
+            throw ex;
         }
     };
     return HttpClientBackendService;