-
Notifications
You must be signed in to change notification settings - Fork 3.4k
datepicker: migrate to use mdPanel container #9564
Comments
@ErinCoughlan I got the datepicker positioning working without too much hassle, however I ran in a couple of issues that could be solved in the panel:
mdPanelPosition.withOffsetX(function(dimensionOfTargetElement) {
return whateverOffsetShouldBeSet; // this can be based on the passed in dimensions.
}); Point 2 could technically be done in the |
@crisbeto I like the idea of allowing a function as well as assuming the 'px' if supplied a number. I think that can help prevent some user errors. Please file separate Issues for each of those bugs and we can tackle them to improve the datepicker. |
@ErinCoughlan another one I ran into: at the moment, you can set the panel to close via clicking outside or pressing escape, however the datepicker also has the case where it closes the calendar if the user tabs away. Do you think it makes sense to have the "close on" keys configurable through |
@crisbeto I think tab makes a lot of sense. That's also used in popovers, basically if you tab past the end, focus leaves instead of being trapped. I'm wondering two things in terms of use and API:
|
|
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
@ErinCoughlan I went back to this after #9651 got merged and I noticed a couple of issues:
|
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Migrates the datepicker's positioning logic to mdPanel. All the functionality should work as before. Fixes angular#9564.
Tracking issue for using the mdPanel in datepicker. Any related issues that appear during the migration should refer to this issue as a primary use case.
The text was updated successfully, but these errors were encountered: