Fix delete rule event consumption for wildcard index based rules (opensearch-project#18628)

---------

Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>

Author: kaushalmahi12

CHANGELOG.md

@@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ### Fixed
 - Add task cancellation checks in aggregators ([#18426](https://github.com/opensearch-project/OpenSearch/pull/18426))
 - Fix concurrent timings in profiler ([#18540](https://github.com/opensearch-project/OpenSearch/pull/18540))
+- [Autotagging] Fix delete rule event consumption in InMemoryRuleProcessingService ([#18628](https://github.com/opensearch-project/OpenSearch/pull/18628))
 - Cannot communicate with HTTP/2 when reactor-netty is enabled ([#18599](https://github.com/opensearch-project/OpenSearch/pull/18599))
 - Fix the visit of sub queries for HasParentQuery and HasChildQuery ([#18621](https://github.com/opensearch-project/OpenSearch/pull/18621))
 

modules/autotagging-commons/src/main/java/org/opensearch/rule/InMemoryRuleProcessingService.java

@@ -66,7 +66,7 @@ private void perform(Rule rule, BiConsumer<Map.Entry<Attribute, Set<String>>, Ru
     private void removeOperation(Map.Entry<Attribute, Set<String>> attributeEntry, Rule rule) {
         AttributeValueStore<String, String> valueStore = attributeValueStoreFactory.getAttributeValueStore(attributeEntry.getKey());
         for (String value : attributeEntry.getValue()) {
-            valueStore.remove(value);
+            valueStore.remove(value.replace(WILDCARD, ""));
         }
     }
 

modules/autotagging-commons/src/test/java/org/opensearch/rule/InMemoryRuleProcessingServiceTests.java

@@ -53,6 +53,16 @@ public void testRemove() {
         assertFalse(label.isPresent());
     }
 
+    public void testAddThenRemoveWithWildcard() {
+        Rule rule = getRule(Set.of("test-*"), "test_id");
+        sut.add(rule);
+        sut.remove(rule);
+
+        List<AttributeExtractor<String>> extractors = getAttributeExtractors(List.of("test-index"));
+        Optional<String> label = sut.evaluateLabel(extractors);
+        assertFalse(label.isPresent());
+    }
+
     public void testEvaluateLabelForExactMatch() {
         sut.add(getRule(Set.of("test1", "change"), "test_id"));
         sut.add(getRule(Set.of("test", "double"), "test_id1"));