Remove exclusions from breaking changes check (post 3.1.0 release) (opensearch-project#18632)

Signed-off-by: Andriy Redko <[email protected]>

Author: reta

server/build.gradle

@@ -404,21 +404,6 @@ tasks.register("japicmp", me.champeau.gradle.japicmp.JapicmpTask) {
     failOnSourceIncompatibility = true
     annotationIncludes = ['@org.opensearch.common.annotation.PublicApi', '@org.opensearch.common.annotation.DeprecatedApi']
     annotationExcludes = ['@org.opensearch.common.annotation.InternalApi']
-    // Already broken APIs, excluding them for now
-    classExcludes = [
-        "org.opensearch.action.DocWriteRequest",
-        "org.opensearch.cluster.ClusterInfo",
-        "org.opensearch.cluster.service.PendingClusterTask",
-        "org.opensearch.index.IndexService",
-        "org.opensearch.indices.IndicesService",
-        "org.opensearch.index.IndexModule",
-        "org.opensearch.index.store.remote.filecache.FileCacheStats",
-        "org.opensearch.index.store.remote.filecache.FileCache",
-        "org.opensearch.index.store.remote.utils.cache.CacheUsage",
-        "org.opensearch.index.store.remote.utils.cache.stats.CacheStats",
-        "org.opensearch.index.query.QueryCoordinatorContext",
-        "org.opensearch.index.shard.IndexShard"
-    ]
     txtOutputFile = layout.buildDirectory.file("reports/java-compatibility/report.txt")
     htmlOutputFile = layout.buildDirectory.file("reports/java-compatibility/report.html")
     dependsOn downloadJapicmpCompareTarget

server/src/main/java/org/opensearch/cluster/ClusterInfo.java

@@ -78,6 +78,29 @@ protected ClusterInfo() {
         this(Map.of(), Map.of(), Map.of(), Map.of(), Map.of(), Map.of(), Map.of());
     }
 
+    /**
+     * Creates a new ClusterInfo instance.
+     *
+     * @param leastAvailableSpaceUsage a node id to disk usage mapping for the path that has the least available space on the node.
+     * @param mostAvailableSpaceUsage  a node id to disk usage mapping for the path that has the most available space on the node.
+     * @param shardSizes a shardkey to size in bytes mapping per shard.
+     * @param routingToDataPath the shard routing to datapath mapping
+     * @param reservedSpace reserved space per shard broken down by node and data path
+     * @param nodeFileCacheStats node file cache stats
+     * @see #shardIdentifierFromRouting
+     */
+    @Deprecated(forRemoval = true)
+    public ClusterInfo(
+        final Map<String, DiskUsage> leastAvailableSpaceUsage,
+        final Map<String, DiskUsage> mostAvailableSpaceUsage,
+        final Map<String, Long> shardSizes,
+        final Map<ShardRouting, String> routingToDataPath,
+        final Map<NodeAndPath, ReservedSpace> reservedSpace,
+        final Map<String, AggregateFileCacheStats> nodeFileCacheStats
+    ) {
+        this(leastAvailableSpaceUsage, mostAvailableSpaceUsage, shardSizes, routingToDataPath, reservedSpace, nodeFileCacheStats, Map.of());
+    }
+
     /**
      * Creates a new ClusterInfo instance.
      *

server/src/main/java/org/opensearch/index/IndexService.java

@@ -590,6 +590,34 @@ private long getAvgShardSizeInBytes() throws IOException {
         }
     }
 
+    @Deprecated(forRemoval = true)
+    public synchronized IndexShard createShard(
+        final ShardRouting routing,
+        final Consumer<ShardId> globalCheckpointSyncer,
+        final RetentionLeaseSyncer retentionLeaseSyncer,
+        final SegmentReplicationCheckpointPublisher checkpointPublisher,
+        final RemoteStoreStatsTrackerFactory remoteStoreStatsTrackerFactory,
+        final RepositoriesService repositoriesService,
+        final DiscoveryNode targetNode,
+        @Nullable DiscoveryNode sourceNode,
+        DiscoveryNodes discoveryNodes,
+        MergedSegmentWarmerFactory mergedSegmentWarmerFactory
+    ) throws IOException {
+        return createShard(
+            routing,
+            globalCheckpointSyncer,
+            retentionLeaseSyncer,
+            checkpointPublisher,
+            remoteStoreStatsTrackerFactory,
+            repositoriesService,
+            targetNode,
+            sourceNode,
+            discoveryNodes,
+            mergedSegmentWarmerFactory,
+            null
+        );
+    }
+
     public synchronized IndexShard createShard(
         final ShardRouting routing,
         final Consumer<ShardId> globalCheckpointSyncer,

server/src/main/java/org/opensearch/indices/IndicesService.java

@@ -1219,6 +1219,40 @@ public synchronized void verifyIndexMetadata(IndexMetadata metadata, IndexMetada
         }
     }
 
+    @Deprecated(forRemoval = true)
+    public IndexShard createShard(
+        final ShardRouting shardRouting,
+        final SegmentReplicationCheckpointPublisher checkpointPublisher,
+        final PeerRecoveryTargetService recoveryTargetService,
+        final RecoveryListener recoveryListener,
+        final RepositoriesService repositoriesService,
+        final Consumer<IndexShard.ShardFailure> onShardFailure,
+        final Consumer<ShardId> globalCheckpointSyncer,
+        final RetentionLeaseSyncer retentionLeaseSyncer,
+        final DiscoveryNode targetNode,
+        final DiscoveryNode sourceNode,
+        final RemoteStoreStatsTrackerFactory remoteStoreStatsTrackerFactory,
+        final DiscoveryNodes discoveryNodes,
+        final MergedSegmentWarmerFactory mergedSegmentWarmerFactory
+    ) throws IOException {
+        return createShard(
+            shardRouting,
+            checkpointPublisher,
+            recoveryTargetService,
+            recoveryListener,
+            repositoriesService,
+            onShardFailure,
+            globalCheckpointSyncer,
+            retentionLeaseSyncer,
+            targetNode,
+            sourceNode,
+            remoteStoreStatsTrackerFactory,
+            discoveryNodes,
+            mergedSegmentWarmerFactory,
+            null
+        );
+    }
+
     @Override
     public IndexShard createShard(
         final ShardRouting shardRouting,