Filtered deck overview doesn't update properly after rebuilding

[ZornHadNoChoice]

Checked for duplicates?

• This issue is not a duplicate

Does it also happen in the desktop version?

• This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

1. Make a filtered deck which successfully pulls some cards (i.e. is not empty).
2. Long press the deck and empty it.
3. Open the deck. You should see the congratulation screen.
4. Tap the button in the top right corner and rebuild the deck.

The deck overview still says "Congratulations...".

Expected behaviour

It should show the usual numbers and study button like this:

Debug info

AnkiDroid Version = 2.25.0alpha2 (ad96da5a09ab3aaa3ddebb4928067c73168ff6c6)  
Backend Version = 0.1.64-anki25.09.2 (25.09.2 3890e12c9e48c028c3f12aa58cb64bd9f8895e30)  
Android Version = 13 (SDK 33)  
ProductFlavor = full  
Device Info = Xiaomi | POCO | mondrian | mondrian_global | 23013PC75G | qcom  
WebView Info = [com.google.android.webview | 787104603]: Mozilla/5.0 (Linux; Android 13; 23013PC75G Build/TKQ1.220905.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/150.0.7871.46 Mobile Safari/537.36  
ACRA UUID = 4afc3b3f-e93f-4a66-bc71-2b9476ef9eb0  
FSRS = 5.1.0 (Enabled: true)  
Crash Reports Enabled = true

(Optional) Anything else you want to share?

The padding in the congratulations screen is too small.

Research

• I have checked the manual and the FAQ and could not find a solution to my issue
• (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

[jatinkumar2409]

@david-allison I would like to work on this

[david-allison]

Ok, thanks!

[jatinkumar2409]

@david-allison @ZornHadNoChoice I was able to reproduce the issue, but I couldn't identify the root cause. I'd like to unassign myself so a maintainer can take a closer look.

Thanks

[Ayush-Patel-56]

can I take this one?

traced it down, CongratsPage just does webViewLayout.reload() whenever studyQueues changes, doesn't check if the deck actually still has cards due. so rebuild pulls cards back in but it reloads the same congrats html anyway. desktop doesn't hit this since Overview re-checks is_finished() on every refresh and swaps between congrats/study html, AnkiDroid never ported that check over when it split congrats into its own screen.

have a fix + a test reproducing these exact steps working locally, assign me and I open the PR