Skip to content

Commit c7fd68a

Browse files
author
Shelley Lambert
authored
Merge pull request adoptium#149 from renfeiw/vendor
Add feature to disable vendor
2 parents 554050f + feae244 commit c7fd68a

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

scripts/testBot/disable.py

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ def main():
3838
newArgs["file"] = m.group(1)
3939
elif m := re.match(r"impl=(\S+)", op):
4040
newArgs["impl"] = m.group(1)
41+
elif m := re.match(r"vendor=(\S+)", op):
42+
newArgs["vendor"] = m.group(1)
4143
elif m := re.match(r"ver=(\S+)", op):
4244
newArgs["ver"] = m.group(1)
4345
elif m := re.match(r"plat=(\S+)", op):

scripts/testBot/playlistModifier.py

+5
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ def main():
2828
ap.add_argument("-t", "--test", required=False, help="test name")
2929
ap.add_argument("-v", "--ver", required=False, help="java version")
3030
ap.add_argument("-i", "--impl", required=False, help="java impl")
31+
ap.add_argument("-vd", "--vendor", required=False, help="java vendor")
3132
ap.add_argument("-p", "--plat", required=False, help="platform")
3233
ap.add_argument("-c", "--comment", required=False, help="comment")
3334
run(vars(ap.parse_args()))
@@ -92,6 +93,10 @@ def addDisabled(files, args):
9293
implEle = etree.Element("impl")
9394
implEle.text = args["impl"]
9495
disabled.append(implEle)
96+
if "vendor" in args:
97+
vendorEle = etree.Element("vendor")
98+
vendorEle.text = args["vendor"]
99+
disabled.append(vendorEle)
95100
if "plat" in args:
96101
platEle = etree.Element("plat")
97102
platEle.text = args["plat"]

src/org/testKitGen/TestInfoParser.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,15 @@ private void parseDisableInfo(TestInfo ti) {
188188
}
189189

190190
String impl = getDisabledEle(disabled, "impl", ti.getTestCaseName());
191+
String vendor = getDisabledEle(disabled, "vendor", ti.getTestCaseName());
191192
String subset = getDisabledEle(disabled, "subset", ti.getTestCaseName());
192193
String plat = getDisabledEle(disabled, "plat", ti.getTestCaseName());
193194
String variation = getDisabledEle(disabled, "variation", ti.getTestCaseName());
194195

195196
for (Variation var : ti.getVars()) {
196-
if (((impl == null) || arg.getImpl().equals(impl))
197-
&& ((subset == null) || checkJavaVersion(subset))
197+
if (((impl == null) || arg.getImpl().equals(impl))
198+
&& ((vendor == null) || arg.getVendor().equals(vendor))
199+
&& ((subset == null) || checkJavaVersion(subset))
198200
&& ((plat == null) || checkPlat(plat))
199201
&& ((variation == null) || var.getVariation().equals(variation))) {
200202
var.addDisabledReasons(comment);

0 commit comments

Comments
 (0)