Update CI runners and documentation to not run on Ubuntu 20.04 (UBC-Thunderbots#3427)

* remove references to Ubuntu 20.04 and update CI

* take up vincent's suggestion

* Update CI installation dependencies

* possibly fix precommit

* fix pre-commit

* [pre-commit.ci lite] apply automatic fixes

* fix systemd hook

* maybe the issue is default initialization?

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Author: itsarune

.github/workflows/main.yml

@@ -14,7 +14,7 @@ jobs:
   multiplatform-build:
     strategy:
       matrix:
-        platform: [ ubuntu-22.04, ubuntu-24.04 ]
+        platform: [ ubuntu-24.04 ]
 
     name: Ubuntu Alternate Builds
     runs-on: ${{ matrix.platform }}
@@ -50,7 +50,7 @@ jobs:
 
   software-tests:
     name: Software Tests
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       # checks-out the repository under $GITHUB_WORKSPACE
       - uses: actions/checkout@v4
@@ -72,7 +72,7 @@ jobs:
 
   robot-tests:
     name: Robot Software Tests
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       # checks-out the repository under $GITHUB_WORKSPACE
       - uses: actions/checkout@v4
@@ -108,7 +108,7 @@ jobs:
 
   simulated-gameplay-tests:
     name: Simulated Gameplay Tests
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       # checks-out the repository under $GITHUB_WORKSPACE
       - uses: actions/checkout@v4
@@ -146,7 +146,7 @@ jobs:
 
   autorefd-game:
     name: AutoRef'd Game (3 Minutes)
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       # checks-out the repository under $GITHUB_WORKSPACE
       - uses: actions/checkout@v4

.github/workflows/pre-commit.yml

@@ -14,7 +14,7 @@ concurrency:
 jobs:
   formatting-check:
     name: Formatting and FSM diagram generation with pre-commit-ci-lite
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     if: github.event.pull_request.draft == false
     steps:
       # checks-out the repository under $GITHUB_WORKSPACE
@@ -27,9 +27,9 @@ jobs:
       - name: Install pip
         run: curl -sS https://bootstrap.pypa.io/get-pip.py | python
 
-      - uses: pre-commit/[email protected].0
+      - uses: pre-commit/[email protected].1
 
-      - uses: pre-commit-ci/lite-action@v1.0.1
+      - uses: pre-commit-ci/lite-action@v1.1.0
         name: Run pre-commit-ci-lite
         if: always()
 

docs/getting-started-wsl.md

@@ -39,7 +39,7 @@ If you are not using Windows 11 and would prefer not to upgrade, you can follow
 3. Now, let's install Ubuntu.
     - Download the WSL2 kernel from [here](https://docs.microsoft.com/en-us/windows/wsl/wsl2-kernel).
     - Open a PowerShell window and run command `wsl --set-default-version 2` to use WSL2 by default.
-    - Install Ubuntu 20.04 LTS, Ubuntu 22.04 LTS or Ubuntu 24.04 LTS from the Microsoft Store.
+    - Install Ubuntu 22.04 LTS or Ubuntu 24.04 LTS from the Microsoft Store.
     - Open the Ubuntu app in the Start menu. It will open a command prompt and ask you to create a new UNIX username and password for your WSL2 Ubuntu installation. 
 
 ### X Server Setup

docs/getting-started.md

@@ -68,13 +68,13 @@ These instructions assume you have a basic understanding of Linux and the comman
 
 We currently only support Linux, specifically Ubuntu.
 
-If you have a X86_64 machine, we support Ubuntu 20.04 LTS, Ubuntu 22.04 LTS and Ubuntu 24.04 LTS.
+If you have a X86_64 machine, we support Ubuntu 22.04 LTS and Ubuntu 24.04 LTS.
 
 If you have a ARM64 (also known as AARCH64) machine, we support Ubuntu 24.04 LTS.
 
 You are welcome to use a different version or distribution of Linux, but may need to make some tweaks in order for things to work.
 
-You can use Ubuntu 20.04 LTS, Ubuntu 22.04 LTS or Ubuntu 24.04 LTS inside Windows through Windows Subsystem for Linux, by following [this guide](./getting-started-wsl.md). **Running and developing Thunderbots on Windows is experimental and not officially supported.**
+You can use Ubuntu 22.04 LTS or Ubuntu 24.04 LTS inside Windows through Windows Subsystem for Linux, by following [this guide](./getting-started-wsl.md). **Running and developing Thunderbots on Windows is experimental and not officially supported.**
 
 ### Getting the Code
 

environment_setup/setup_software.sh

@@ -104,6 +104,11 @@ if [[ $(lsb_release -rs) == "22.04" ]] || [[ $(lsb_release -rs) == "24.04" ]]; t
     sudo mv /tmp/tbots_download_cache/85-brltty.rules /usr/lib/udev/rules.d/85-brltty.rules 
 fi
 
+if [[ $(lsb_release -rs) == "22.04" ]]; then
+    # This is required for clang-format
+    host_software_packages+=(libtinfo5)
+fi
+
 virtualenv_opt_args=""
 if [[ $(lsb_release -rs) == "24.04" ]]; then
     host_software_packages+=(python3-pyqt6)

src/software/embedded/ansible/tasks/setup_systemd.yml

@@ -16,8 +16,9 @@
         copy_links: true
 
     - name: Compute Thunderloop MD5 Hash
-      command: '/home/{{ ansible_user }}/hash_thunderloop_binary.sh'
+      ansible.builtin.command: "/home/{{ ansible_user }}/hash_thunderloop_binary.sh"
       register: result
+      changed_when: true
 
     - name: Sync Thunderloop systemd file
       become_method: ansible.builtin.sudo

src/software/estop/threaded_estop_reader_test.cpp

@@ -44,7 +44,7 @@ TEST(ThreadedEstopReaderTest, estop_tick_is_called_multiple_times)
     std::mutex m;
     std::unique_lock lock(m);
     std::condition_variable cv;
-    bool ready;
+    bool ready = false;
 
     EXPECT_CALL(*mock_uart_ptr, flushSerialPort(_)).WillRepeatedly(Return(true));