perf improvements

Author: tchughesiv

Diff for: Dockerfile

@@ -131,3 +131,5 @@ COPY roles /opt/ansible/roles
 RUN chown -R apb:0 /opt/{ansible,apb} && \
     chmod -R g=u /opt/{ansible,apb}
 USER apb
+ENV ANSIBLE_PIPELINING=True \
+    ANSIBLE_CALLBACK_WHITELIST=profile_tasks

Diff for: playbooks/deprovision.yml

@@ -1,7 +1,7 @@
 ---
 - name: mssql-apb playbook to deprovision the application
   hosts: localhost
-  gather_facts: false
+  gather_facts: False
   connection: local
   roles:
   - role: ansible.kubernetes-modules

Diff for: playbooks/provision.yml

@@ -1,7 +1,7 @@
 ---
 - name: mssql-apb playbook to provision the application
   hosts: localhost
-  gather_facts: false
+  gather_facts: False
   connection: local
   roles:
   - role: ansible.kubernetes-modules

Diff for: playbooks/test.yml

@@ -1,7 +1,7 @@
 ---
 - name: "[MSSQL-APB] [TEST] Test MSSQL APB"
   hosts: localhost
-  gather_facts: false
+  gather_facts: False
   connection: local
   roles:
   - role: ansible.kubernetes-modules

Diff for: roles/deprovision-mssql-apb/tasks/main.yml

@@ -14,6 +14,9 @@
     name: '{{ service_instance }}'
     namespace: '{{ namespace }}'
     state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: rm_svc
 
 
 ##############################################################################
@@ -25,6 +28,9 @@
     name: '{{ service_instance }}'
     namespace: '{{ namespace }}'
     state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: rm_dc
 
 
 ##############################################################################
@@ -34,3 +40,25 @@
     name: '{{ service_instance }}'
     namespace: '{{ namespace }}'
     state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: rm_secret
+
+
+- name: 'Check on service task'
+  async_status: jid={{ rm_svc.ansible_job_id }}
+  register: svc_job_result
+  until: svc_job_result.finished
+  retries: 60
+
+- name: 'Check on DC task'
+  async_status: jid={{ rm_dc.ansible_job_id }}
+  register: dc_job_result
+  until: dc_job_result.finished
+  retries: 60
+
+- name: 'Check on secret task'
+  async_status: jid={{ rm_secret.ansible_job_id }}
+  register: s_job_result
+  until: s_job_result.finished
+  retries: 60

Diff for: roles/provision-mssql-apb/tasks/main.yml

@@ -14,14 +14,47 @@
       - name: '{{ mssql_image_tag }}'
     docker_image_repository: '{{ mssql_image }}'
     state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: create_is
   when: mssql_local != true
 
+- name: Create secret
+  k8s_v1_secret:
+    name: '{{ service_instance }}'
+    namespace: '{{ namespace }}'
+    string_data:
+      ACCEPT_EULA: "Y"
+      MSSQL_SA_PASSWORD: '{{ mssql_sa_pw }}'
+      MSSQL_PID: '{{ mssql_pid }}'
+      MSSQL_LCID: '{{ mssql_lcid | string }}'
+      MSSQL_AGENT_ENABLED: '{{ mssql_agent | string }}'
+      MSSQL_MEMORY_LIMIT_MB: '{{ (( memory_limit | int ) * 1000 ) | string }}'
+    state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: create_secret
+
+- name: Create PVC for persistent deployment
+  k8s_v1_persistent_volume_claim:
+    name: '{{ service_instance }}'
+    namespace: '{{ namespace }}'
+    access_modes:
+      - ReadWriteOnce
+    resources_requests:
+      storage: '{{ volume_size }}G'
+    state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: create_pvc
+  when: _apb_plan_id == "persistent"
+
 
 ##############################################################################
 ## A Kubernetes service serves as an internal load balancer.  It identifies a
 ## set of replicated pods in order to proxy the connections it receives to them.
 ##############################################################################
-- name: Create '{{ service_instance }}' service
+- name: Create service
   k8s_v1_service:
     name: '{{ service_instance }}'
     namespace: '{{ namespace }}'
@@ -37,7 +70,7 @@
         target_port: 1433
     state: '{{ state }}'
 
-- name: Create '{{ service_name }}' service
+- name: Create '{{ service_name }}' CNAME service
   k8s_v1_service:
     name: '{{ service_name }}'
     namespace: '{{ namespace }}'
@@ -54,6 +87,9 @@
         port: '{{ service_port }}'
         target_port: 1433
     state: '{{ state }}'
+  async: 180
+  poll: 0
+  register: create_svc_cname
 
 
 ##############################################################################
@@ -198,30 +234,6 @@
     state: '{{ state }}'
   when: _apb_plan_id == "persistent"
 
-- name: Create secret
-  k8s_v1_secret:
-    name: '{{ service_instance }}'
-    namespace: '{{ namespace }}'
-    string_data:
-      ACCEPT_EULA: "Y"
-      MSSQL_SA_PASSWORD: '{{ mssql_sa_pw }}'
-      MSSQL_PID: '{{ mssql_pid }}'
-      MSSQL_LCID: '{{ mssql_lcid | string }}'
-      MSSQL_AGENT_ENABLED: '{{ mssql_agent | string }}'
-      MSSQL_MEMORY_LIMIT_MB: '{{ (( memory_limit | int ) * 1000 ) | string }}'
-    state: '{{ state }}'
-
-- name: Create PVC for persistent deployment
-  k8s_v1_persistent_volume_claim:
-    name: '{{ service_instance }}'
-    namespace: '{{ namespace }}'
-    access_modes:
-      - ReadWriteOnce
-    resources_requests:
-      storage: '{{ volume_size }}G'
-    state: '{{ state }}'
-  when: _apb_plan_id == "persistent"
-
 
 ##############################################################################
 ## Encode bind credentials.
@@ -238,6 +250,32 @@
       DB_URI: 'Data Source={{ service_instance }}.{{ namespace }}.svc,{{ service_port }}; Initial Catalog={{ mssql_db }}; User Id=SA; Password={{ mssql_sa_pw }};'
   when: action == 'provision'
 
+- name: 'Check on ImageStream task'
+  async_status: jid={{ create_is.ansible_job_id }}
+  register: is_job_result
+  until: is_job_result.finished
+  retries: 60
+  when: mssql_local != true
+
+- name: 'Check on secret task'
+  async_status: jid={{ create_secret.ansible_job_id }}
+  register: s_job_result
+  until: s_job_result.finished
+  retries: 60
+
+- name: 'Check on PVC task'
+  async_status: jid={{ create_pvc.ansible_job_id }}
+  register: pvc_job_result
+  until: pvc_job_result.finished
+  retries: 60
+  when: _apb_plan_id == "persistent"
+
+- name: 'Check on service CNAME task'
+  async_status: jid={{ create_svc_cname.ansible_job_id }}
+  register: csvc_job_result
+  until: csvc_job_result.finished
+  retries: 60
+
 - name: Wait for mssql to come up
   wait_for:
     host: '{{ service_instance }}.{{ namespace }}.svc'