fix: contextmenu cant be scrolled#7638
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request moves the registration of the wheel event listener for the context menu from the initialization phase to the bindEvents method, which prevents wheel events from bubbling up and triggering canvas zoom logic. A review comment identifies a potential issue where the context menu might close unexpectedly when users interact with internal elements like scrollbars, suggesting an improvement to the click handling logic to ensure better usability.
|
|
||
| document.addEventListener('click', this.onMenuItemClick); | ||
| // 阻止滚轮事件冒泡，防止触发画布的 zoom-canvas 拦截逻辑 | ||
| this.$element.addEventListener('wheel', this.wheelHandler); |
There was a problem hiding this comment.
这个修改解决了通过滚轮滚动菜单时触发画布缩放的问题。但是，我注意到 onMenuItemClick（第 244 行）的逻辑存在一个潜在问题：当用户点击菜单内部（例如点击滚动条进行拖动）但未点击到具体的菜单项时，如果 trigger 配置不是 'click'（默认是 'contextmenu'），菜单会因为触发了 document 上的点击事件而关闭。这会导致用户无法通过拖动滚动条来滚动菜单。建议后续优化 onMenuItemClick 的逻辑，增加对点击位置是否在菜单内部的判断，以确保滚动条操作的正常进行。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v5 #7638 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 188 188
Lines 10031 10031
Branches 2171 2171
=======================================
Hits 9525 9525
Misses 468 468
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2 participants
修复Contextmenu无法滚动的问题
Graph 初始化时，Contextmenu 的这三个函数触发顺序是这样的
initElement()->unbindEvents()->bindEvents()，导致wheelHandler添加后接着被移除将
addEventListener从initElement中移动到bindEvents即可解决