Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Dive deadline storage method #43989

Open
ferruzzi opened this issue Nov 13, 2024 · 2 comments
Open

Deep Dive deadline storage method #43989

ferruzzi opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@ferruzzi
Copy link
Contributor

Determine storage method (in the DAG object or in a DB table or ??? )

  • Must be able to sort/search by "need-by" and remove by "dagrun_id"
  • Must be able to allow alternative remove options for task_id or other options for future work
@ferruzzi ferruzzi self-assigned this Nov 13, 2024
@ferruzzi ferruzzi moved this to In Progress in AIP-86: Deadline Alerts Nov 13, 2024
@ferruzzi ferruzzi changed the title Deep Dive storage method Deep Dive deadline storage method Nov 13, 2024
@ferruzzi
Copy link
Contributor Author

ferruzzi commented Nov 13, 2024

Current thought:

A new table in the DB which has a 1:1 mapping for identifier:deadline, where identifier can be a dagrun_id, task_id, etc. and a query which returns the deadlines filtered to only return the ones which have passed

@ferruzzi
Copy link
Contributor Author

If we are only storing dagrun_id and task_id in the identifier column then it's easy to infer what type of id it is from the format, but does every possible future identifier type have a name format where we can infer what it is from the pattern? Presumably not? So we likely need a type column as well just to be safe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant