Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#44012 - Update index.rst #44034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#44012 - Update index.rst #44034

wants to merge 1 commit into from

Conversation

amirmor1
Copy link
Contributor

@amirmor1 amirmor1 commented Nov 14, 2024

closes: #44012


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amirmor1 amirmor1 changed the title 44012 - Update index.rst #44012 - Update index.rst Nov 14, 2024
Example DAGs <https://github.com/apache/airflow/tree/providers-docker/|version|/providers/tests/system/docker>
Example DAGs <https://github.com/apache/airflow/tree/providers-docker/|version|/tests/system/providers/docker>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be wrong for all providers.
can you apply a fix for all?

@kaxil
Copy link
Member

kaxil commented Nov 14, 2024

Could you please update the PR title? The current one is a bit vague and doesn’t clearly communicate the purpose of the change. I recommend reading this blog post for guidance.

In particular, it would be helpful to follow this principle:

A properly formed Git commit subject line should always be able to complete the following sentence: “If applied, this commit will [your subject line here].”

Since this entry will appear in the release notes, it’s important that the PR title and description clearly explain the changes and their impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to docker provider example dags
4 participants