Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit to validate provider __init__ is matching the template #44024

Open
1 task done
eladkal opened this issue Nov 14, 2024 · 1 comment
Open
1 task done

Add pre-commit to validate provider __init__ is matching the template #44024

eladkal opened this issue Nov 14, 2024 · 1 comment
Labels
area:CI Airflow's tests and continious integration area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code kind:meta High-level information important to the community kind:task A task that needs to be completed as part of a larger issue

Comments

@eladkal
Copy link
Contributor

eladkal commented Nov 14, 2024

Body

To avoid issues like: #44017

Some info about templating of __init__
https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#optional-apply-template-updates

The pre commit should fail if someone modify the init to a pattern that doesn't match the template

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added area:CI Airflow's tests and continious integration kind:meta High-level information important to the community kind:task A task that needs to be completed as part of a larger issue labels Nov 14, 2024
@dosubot dosubot bot added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Nov 14, 2024
@potiuk
Copy link
Member

potiuk commented Nov 14, 2024 •
edited
Loading

FYI. There is a nice way to create an issue by maintainer - create an item in a project and convert it to the issue - this way you can bypass the meta task template :)

@potiuk potiuk moved this to Ready in CI / CD planned work Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:CI Airflow's tests and continious integration area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code kind:meta High-level information important to the community kind:task A task that needs to be completed as part of a larger issue
Projects
CI / CD planned work
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@potiuk @eladkal